FTUE - Sign in #5995
Merged
FTUE - Sign in #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
added
Z-FTUE
ouchadam
commented
May 9, 2022
| @@ -119,40 +120,43 @@ class FtueAuthLoginFragment @Inject constructor() : AbstractSSOFtueAuthFragment< | |||
| } | |||
|
|
|||
| private fun submit() { | |||
| cleanupUi() | |||
| withState(viewModel) { state -> | |||
There was a problem hiding this comment.
this block is an indentation change due to needing the state in order to create the AuthenticateAction from the SignMode, this isn't needed by the new combined fragments as they don't share the same fragment
6 tasks
6 tasks
ouchadam
force-pushed
the
feature/adm/ftue-sign-in
branch
from
9a28949 to
3a5fe5f
Compare
ouchadam
requested review from
a team,
onurays,
ganfra and
ericdecanini
and removed request for
a team and
onurays
ganfra
approved these changes
May 24, 2022
| @@ -521,6 +524,21 @@ interface FragmentModule { | |||
| @FragmentKey(FtueAuthPersonalizationCompleteFragment::class) | |||
| fun bindFtueAuthPersonalizationCompleteFragment(fragment: FtueAuthPersonalizationCompleteFragment): Fragment | |||
|
|
|||
| @Binds | |||
There was a problem hiding this comment.
Had we not decided to start using hilt for fragment too?
There was a problem hiding this comment.
not yet but there's a plan that I'm very excited for 😄 #5420
there's a lot of onboarding fragments
- temporarily to the combined register fragment
- also removes the subtitle view which is not needed for login
- extracting login fields validation - renaming xml fields to login - renaming direct login property to matrixId
- extracts helpers to make the logic more declarative
…hem and showing SSO options when available
ouchadam
force-pushed
the
feature/adm/ftue-sign-in
branch
from
a0fcef6 to
8c44c98
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Uses the updated combined sign in screen for the sign in flow (a slightly tweaked version of the sign up #5648)
DirectLogin, removing the ambiguity aroundLoginOrRegisterMotivation and context
Fixes #5283
Forgot password and editing server selection tweaks will be done in another PR
Screenshots / GIFs
Tests
I already have an accountTested devices