SDK - Avoid resetting login state when calling AuthenticationService.getLoginFlow

[ouchadam]

Type of change

• Feature
• Bugfix
• Technical - SDK change
• Other :

Content

Fixes #6093

Avoids resetting the internal authentication state when calling getLoginFlow until the flow is successfully fetched.

Motivation and context

To allow the UX flow of defaulting to a valid homeserver, editing with an invalid url and then returning to the previously selected homeserver.

Screenshots / GIFs

BEFORE	AFTER

Tests

• Start the sign in process
• Edit the homeserver url to an invalid url and press next
• After seeing the error quit the edit server screen
• Continue to sign in with the previously selected homeserver
• Notice a crash

Tested devices

• Physical
• Emulator
• OS version(s): 31

[github-actions]

Unit Test Results

122 files  ±0  122 suites  ±0   2m 13s ⏱️ -14s
208 tests ±0  208 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
702 runs  ±0  702 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1898b94. ± Comparison against base commit 9a28949.

[bmarty]

Thanks!

[onurays]

Checked the commit history to see if we have an edge case here, nothing suspicious. LGTM!

[bmarty]

(auto-merge would be nice if the CI was not stuck so often...)

FTR:

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  = passed=20 failures=0 errors=0 skipped=3
• [org.matrix.android.sdk.account]
  = passed=3 failures=0 errors=0 skipped=2
• [org.matrix.android.sdk.internal]
  = passed=23 failures=1 errors=0 skipped=1
• [org.matrix.android.sdk.ordering]
  = passed=16 failures=0 errors=0 skipped=0
• [org.matrix.android.sdk.PermalinkParserTest]
  = passed=2 failures=0 errors=0 skipped=0