Replace "open settings" button by "disable" action in RageShake dialog if there is no session

[Florian14]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

The "settings" button is replaced by a "disable" button when there is no session. Clicking on this button will disable the rage shake feature until the user manually reactive it by opening the application settings from a new session.

Motivation and context

Fix #4445

Screenshots / GIFs

Tests

Tested by triggering the rageshake dialog in both states (connected & disconnected).

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[Florian14]

I removed the button to fix a crash but I didn't read the original issue which explains that the setting might stay available by handling the no session state in the settings. Let me know if you prefer to keep the button and go on this way.

[github-actions]

Unit Test Results

110 files  ±0  110 suites  ±0   1m 16s ⏱️ -4s
195 tests ±0  195 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
650 runs  ±0  650 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4d37aa2. ± Comparison against base commit 27b727e.

♻️ This comment has been updated with latest results.

[ouchadam]

is it possible to send a bug report whilst signed out? If not, maybe we could avoid showing the dialog completely?

[bmarty]

is it possible to send a bug report whilst signed out? If not, maybe we could avoid showing the dialog completely?

yes, it is possible, and it works.

[bmarty]

My concern is that it will not be possible to disable rageshake if there is no session, which is the state when a user has just installed the app.
We have seen in the past that sometime the acceleration sensor can be broken and the rageshake dialog appears a lot, which can be really frustrating for the user.

Can we replace the "settings" button by "disable" when there is no session? To let the user be able to disable rageshake detection and be able to create the session.

[Florian14]

@bmarty I updated the PR with your suggestion, let me know if it is ok for you

[bmarty]

That's perfect, thanks for the update!