Hide settings button from rageshake dialog is there is no session

element-hq · Mar 28, 2022 · 6a05d6e · 6a05d6e
1 parent 3cf7765
commit 6a05d6e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog.d/4445.bugfix b/changelog.d/4445.bugfix
@@ -0,0 +1 @@
+Hide settings button from rageshake dialog is there is no session
diff --git a/vector/src/main/java/im/vector/app/features/rageshake/RageShake.kt b/vector/src/main/java/im/vector/app/features/rageshake/RageShake.kt
@@ -24,6 +24,7 @@ import androidx.fragment.app.FragmentActivity
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
 import com.squareup.seismic.ShakeDetector
 import im.vector.app.R
+import im.vector.app.core.di.ActiveSessionHolder
 import im.vector.app.core.hardware.vibrate
 import im.vector.app.features.navigation.Navigator
 import im.vector.app.features.settings.VectorPreferences
@@ -33,6 +34,7 @@ import javax.inject.Inject
 class RageShake @Inject constructor(private val activity: FragmentActivity,
                                     private val bugReporter: BugReporter,
                                     private val navigator: Navigator,
+                                    private val sessionHolder: ActiveSessionHolder,
                                     private val vectorPreferences: VectorPreferences) : ShakeDetector.Listener {
 
     private var shakeDetector: ShakeDetector? = null
@@ -75,7 +77,11 @@ class RageShake @Inject constructor(private val activity: FragmentActivity,
             MaterialAlertDialogBuilder(activity)
                     .setMessage(R.string.send_bug_report_alert_message)
                     .setPositiveButton(R.string.yes) { _, _ -> openBugReportScreen() }
-                    .setNeutralButton(R.string.settings) { _, _ -> openSettings() }
+                    .also {
+                        if (sessionHolder.hasActiveSession()) {
+                            it.setNeutralButton(R.string.settings) { _, _ -> openSettings() }
+                        }
+                    }
                     .setOnDismissListener { dialogDisplayed = false }
                     .setNegativeButton(R.string.no, null)
                     .show()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Hide settings button from rageshake dialog is there is no session