Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crash when tapping timeline verification item #5558

Merged
merged 1 commit into from
Mar 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5540.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes crash when tapping the timeline verification surround box instead of the buttons
Original file line number Diff line number Diff line change
Expand Up @@ -1771,13 +1771,11 @@ class TimelineFragment @Inject constructor(
}
is RoomDetailAction.ResumeVerification -> {
val otherUserId = data.otherUserId ?: return
VerificationBottomSheet().apply {
setArguments(VerificationBottomSheet.VerificationArgs(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this setArguments is actually TimelineFragment.setArguments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, a good example of why I do not like to use apply CC @mnaturel !

otherUserId = otherUserId,
verificationId = data.transactionId,
roomId = timelineArgs.roomId
))
}.show(parentFragmentManager, "REQ")
VerificationBottomSheet.withArgs(
roomId = timelineArgs.roomId,
otherUserId = otherUserId,
transactionId = data.transactionId,
).show(parentFragmentManager, "REQ")
}
}
}
Expand Down