Fixing crash when tapping timeline verification item #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- caused by the setArguments being called on the TimelineFragment not the bottomsheet we've just created
ouchadam
requested review from
a team and
ericdecanini
and removed request for
a team
ouchadam
commented
Mar 16, 2022
| @@ -1771,13 +1771,11 @@ class TimelineFragment @Inject constructor( | |||
| } | |||
| is RoomDetailAction.ResumeVerification -> { | |||
| val otherUserId = data.otherUserId ?: return | |||
| VerificationBottomSheet().apply { | |||
| setArguments(VerificationBottomSheet.VerificationArgs( | |||
There was a problem hiding this comment.
this setArguments is actually TimelineFragment.setArguments
There was a problem hiding this comment.
Ah, a good example of why I do not like to use apply CC @mnaturel !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes the wrong
setArgumentsbeing called when triggering the verification bottom sheetMotivation and context
Fixes a crash when tapping the item area instead of the buttons #5540
Screenshots / GIFs
Tests
Tested devices