[Create private room] Picture doesn't not displayed #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Mar 2, 2022
changelog.d/5402.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| [Create room] Picture doesn't not displayed | |||
There was a problem hiding this comment.
Suggested change
| [Create room] Picture doesn't not displayed | |
| [Create room] Setting an avatar when creating a room had no effect |
...d/src/main/java/org/matrix/android/sdk/internal/session/room/create/CreateRoomBodyBuilder.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| withContext(coroutineDispatchers.io) { | ||
| val response = fileUploader.uploadFromUri(avatarUri, fileName, MimeTypes.Jpeg) | ||
| sendStateEvent( |
There was a problem hiding this comment.
I think this could stay outside of the withContext(coroutineDispatchers.io) block.
There was a problem hiding this comment.
This method is used when we update the picture in the room settings.
It's not working for me in release (i have a popup : "Sorry, an error occurred")but with this fix it's working.
There was a problem hiding this comment.
If i put the with(coroutineDispatchers.io) in here it's working too.
I think it's a better solution to avoid code duplication and always do this action on the io thread.
There was a problem hiding this comment.
Ok, so please do it, it will be cleaner. Thanks!
…al/session/room/create/CreateRoomBodyBuilder.kt Co-authored-by: Benoit Marty <[email protected]>
|
we had a similar issue when changing user avatar |
ouchadam
approved these changes
Mar 3, 2022
onurays
added a commit
that referenced
this pull request
Mar 8, 2022
* develop: (392 commits) Missing import of at-Ignore annotation. FTUE - Choose a display picture (#5323) Ignore ThreadMessagingTest as it seems to cause other integration tests to fail. Maybe the file is here? I give up for the weekend Frustration at artifact handling vs what's in docs. Update the top bar in a room (#5213) Tweak upload/download of codecov xml file Address review points from adam Remove unneeded code, retaining a comment for how to exclude certain projects Merge pull request #5405 from vector-im/cgizard/ISSUE-5402 Remove the printing of file name to the log as it's doubling up information. Remove exclusions (for now). Fix typo in name of action giving avatar/display name error dialogs human readable error messages - reuses the ErrorDialog logic which translates exceptions to human readable strings Run codecoverage and pass to sonarqube upload for processing. Better codecov based on ouchadam's suggestion Correct name of environment variable Use environment variable that is tied to project property Merge pull request #4498 from vector-im/yostyle/fix_strandhogg ... # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/action/MessageActionsViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Upload image in thread io instead of mainThread
Motivation and context
Closes #5402
Screenshots / GIFs
Tests
Tested devices
Checklist