#4642 Update the top bar in a room #5213

ahmed-radhouane · 2022-02-11T17:31:47Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Motivation and context

Update the Shield and the ON/OFF notification within the Room toolbar image.
Remove the subtitle
reduce extra padding for the menu item icons.

Screenshots / GIFs

Dark	Light

Tests

Access to a timeline and check the toolbar.

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

github-actions · 2022-02-11T17:56:37Z

Unit Test Results

  92 files ±0   92 suites ±0 1m 13s ⏱️ +4s
162 tests ±0 162 ✔️ ±0 0 💤 ±0 0 ❌ ±0
524 runs ±0 524 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 0f3e42a. ± Comparison against base commit 6e6b04c.

♻️ This comment has been updated with latest results.

github-actions · 2022-02-11T18:38:47Z

Matrix SDK

Integration Tests Results:

[org.matrix.android.sdk.session]
passed=
[org.matrix.android.sdk.account]
passed=
[org.matrix.android.sdk.internal]
passed=
[org.matrix.android.sdk.ordering]
passed=
[org.matrix.android.sdk.PermalinkParserTest]
passed=

bmarty

I have seen that the PR is draft, but some first remarks.

bmarty · 2022-02-17T15:10:36Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

-                setTypeface(null, Typeface.BOLD)
-            }
+            setTextOrHide(topic)
+            setTextColor(colorProvider.getColorFromAttribute(R.attr.colorPrimary))


I think we want to keep vctr_content_secondary here. Or better declare it in the XML since it will not change anymore.

Done.
Thanks

bmarty · 2022-02-17T15:11:02Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

-            }
+            setTextOrHide(topic)
+            setTextColor(colorProvider.getColorFromAttribute(R.attr.colorPrimary))
+            setTypeface(null, Typeface.BOLD)


Typeface.NORMAL

Done.
Thanks

bmarty · 2022-02-17T15:16:50Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

-    private fun renderSubTitle(typingMessage: String?, topic: String) {
-        // TODO Temporary place to put typing data
-        val subtitle = typingMessage?.takeIf { it.isNotBlank() } ?: topic
+    private fun renderSubTitle(topic: String) {


I think the aim of #4642 is to completely remove the subtitle, so stop displaying the room topic there.

Done.
Thanks

bmarty

Thanks. Some remarks

bmarty · 2022-02-24T13:36:05Z

changelog.d/4642.bugfix

@@ -0,0 +1 @@
+Update the top bar in a room


I would give more details:

Suggested change

Update the top bar in a room

Update the top bar in a room: remove topic and typing information

bmarty · 2022-02-24T13:37:57Z

library/ui-styles/src/main/res/values/theme_common.xml

@@ -25,4 +25,10 @@
        <item name="android:backgroundDimEnabled">false</item>
    </style>

+    <style name="Theme.Vector.ActionButton" parent="@android:style/Widget.ActionButton">


This is not the correct location to add this new style. Can you move it to a new file style_action_button.xml in the same folder please?

bmarty · 2022-02-24T13:39:51Z

library/ui-styles/src/main/res/values/theme_common.xml

@@ -25,4 +25,10 @@
        <item name="android:backgroundDimEnabled">false</item>
    </style>

+    <style name="Theme.Vector.ActionButton" parent="@android:style/Widget.ActionButton">


Please rename the style to Widget.Vector.ActionButton

bmarty · 2022-02-24T13:40:05Z

library/ui-styles/src/main/res/values/theme_common.xml

@@ -25,4 +25,10 @@
        <item name="android:backgroundDimEnabled">false</item>
    </style>

+    <style name="Theme.Vector.ActionButton" parent="@android:style/Widget.ActionButton">


The parent should be Widget.AppCompat.ActionButton I think

bmarty · 2022-02-24T13:40:42Z

library/ui-styles/src/main/res/values/theme_light.xml

    </style>

+
+


Please remove those extra lines.

bmarty · 2022-02-24T13:43:24Z

vector/src/main/res/layout/view_room_detail_toolbar.xml

-        app:layout_constraintTop_toTopOf="@id/roomToolbarTitleView" />
+        android:layout_width="11dp"
+        android:layout_height="13dp"
+        tools:ignore="MissingConstraints"


Please format the file. tools attribute has to be the latest attribute. You can type Maj+Option+Cmd+L in Android Studio to check the box to rearrange code.

bmarty · 2022-02-24T13:53:26Z

vector/src/main/res/layout/view_room_detail_toolbar.xml

-        android:layout_marginStart="7dp"
-        android:layout_marginEnd="8dp"
+        android:layout_marginStart="12dp"
+        android:layout_marginEnd="12dp"


I think you can just delete this View (with id roomToolbarSubtitleView), it's always hidden now, so it's dead code.

- remove typing message notification from room toolbar. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

- update image and badge in room toolbar. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

- remove subtitle in room toolbar. - update shiled and connected icon in toolbar main picture. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

- reduce extra padding between menu item. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

- adding the changelog file. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

- Fixing after code review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

bmarty

Thanks for the update. I will squash and merge.

* develop: (392 commits) Missing import of at-Ignore annotation. FTUE - Choose a display picture (#5323) Ignore ThreadMessagingTest as it seems to cause other integration tests to fail. Maybe the file is here? I give up for the weekend Frustration at artifact handling vs what's in docs. Update the top bar in a room (#5213) Tweak upload/download of codecov xml file Address review points from adam Remove unneeded code, retaining a comment for how to exclude certain projects Merge pull request #5405 from vector-im/cgizard/ISSUE-5402 Remove the printing of file name to the log as it's doubling up information. Remove exclusions (for now). Fix typo in name of action giving avatar/display name error dialogs human readable error messages - reuses the ErrorDialog logic which translates exceptions to human readable strings Run codecoverage and pass to sonarqube upload for processing. Better codecov based on ouchadam's suggestion Correct name of environment variable Use environment variable that is tied to project property Merge pull request #4498 from vector-im/yostyle/fix_strandhogg ... # Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/action/MessageActionsViewModel.kt

ahmed-radhouane marked this pull request as draft February 11, 2022 17:31

ahmed-radhouane force-pushed the arb/issues/3296 branch from 7f51b05 to e3aae38 Compare February 11, 2022 17:53

ahmed-radhouane force-pushed the arb/issues/4642 branch from 0332946 to 58eab76 Compare February 11, 2022 17:58

bmarty reviewed Feb 17, 2022

View reviewed changes

ahmed-radhouane force-pushed the arb/issues/3296 branch from bfd31fb to 0694cb2 Compare February 22, 2022 08:01

ahmed-radhouane force-pushed the arb/issues/4642 branch from 58eab76 to d9f1623 Compare February 22, 2022 08:02

ahmed-radhouane force-pushed the arb/issues/3296 branch from 0694cb2 to 91ab472 Compare February 23, 2022 10:35

ahmed-radhouane force-pushed the arb/issues/4642 branch from 0163e3f to a76d62a Compare February 23, 2022 17:34

ahmed-radhouane marked this pull request as ready for review February 23, 2022 17:34

ahmed-radhouane changed the base branch from arb/issues/3296 to develop February 23, 2022 17:38

ahmed-radhouane force-pushed the arb/issues/4642 branch from a76d62a to fbf8e3b Compare February 23, 2022 18:03

bmarty requested changes Feb 24, 2022

View reviewed changes

ahmed-radhouane force-pushed the arb/issues/4642 branch from a4701c9 to 8c246c2 Compare March 3, 2022 13:30

ahmed-radhouane added 6 commits March 3, 2022 15:28

#4642

71cbfaa

- remove typing message notification from room toolbar. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

#4642

6a3da66

- update image and badge in room toolbar. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

#4642

b06e927

- remove subtitle in room toolbar. - update shiled and connected icon in toolbar main picture. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

#4642

eb58eba

- reduce extra padding between menu item. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

#4642

9cc4014

- adding the changelog file. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

#4642

0f3e42a

- Fixing after code review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>

ahmed-radhouane force-pushed the arb/issues/4642 branch from 8c246c2 to 0f3e42a Compare March 3, 2022 14:28

bmarty approved these changes Mar 4, 2022

View reviewed changes

bmarty merged commit bcdf004 into develop Mar 4, 2022

bmarty deleted the arb/issues/4642 branch March 4, 2022 15:38

ouchadam mentioned this pull request Mar 9, 2022

Update the top bar in a room #4642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#4642 Update the top bar in a room #5213

#4642 Update the top bar in a room #5213

ahmed-radhouane commented Feb 11, 2022 •

edited

Loading

github-actions bot commented Feb 11, 2022 •

edited

Loading

github-actions bot commented Feb 11, 2022 •

edited

Loading

bmarty left a comment

bmarty Feb 17, 2022

ahmed-radhouane Feb 23, 2022

bmarty Feb 17, 2022

ahmed-radhouane Feb 23, 2022

bmarty Feb 17, 2022

ahmed-radhouane Feb 23, 2022

bmarty left a comment

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty Feb 24, 2022

bmarty left a comment

	Update the top bar in a room
	Update the top bar in a room: remove topic and typing information

#4642 Update the top bar in a room #5213

#4642 Update the top bar in a room #5213

Conversation

ahmed-radhouane commented Feb 11, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions bot commented Feb 11, 2022 • edited Loading

Unit Test Results

github-actions bot commented Feb 11, 2022 • edited Loading

Matrix SDK

Integration Tests Results:

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

ahmed-radhouane commented Feb 11, 2022 •

edited

Loading

github-actions bot commented Feb 11, 2022 •

edited

Loading

github-actions bot commented Feb 11, 2022 •

edited

Loading