Live Threads #5298

ariskotsomitopoulos · 2022-02-22T12:52:40Z

This PR closes #5230 closes #5232 closes #5271 closes #5231 closes #5116

Live Thread Summaries

Currently in threads P0 release we can view all the threads within a room but only for the received messages from the main timeline (it is also not working when there are gaps). This PR uses the enhanced /messages API from MSC3440 to dynamically fetch the latest root threads along with their summary for each room. It will also support edited messages (on root message or thread summary)

Live Thread Timeline

Currently in threads P0 release when you open a thread will paginate through /messages api exactly like the main timeline will do. This approach work but there will be a problem with large gaps or large threads, it will try fetch all the messages even when the messages are not from that thread in order to display them. This PR uses the /relations API to fetch and paginate the thread timeline. It will also handle appropriately the already existing events from the main timeline, user will be able to interact smoothly (reactions etc) with them even if the same event has already arrived.

Home Server Capabilities for threads

Some home servers may not support the MSC3440 so we will not be able to use the enhanced /messages api to fetch the thread summaries we described above. This PR will reuse the existing logic like in P0 release in those home servers by using the capabilities api

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/migration/MigrateSessionTo025.kt

… MSC 3440 Add capabilities to support local thread list to not supported servers

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt

github-actions · 2022-02-22T13:24:04Z

Unit Test Results

  98 files ±0   98 suites ±0 1m 3s ⏱️ -16s
180 tests +1 180 ✔️ +1 0 💤 ±0 0 ❌ ±0
590 runs +2 590 ✔️ +2 0 💤 ±0 0 ❌ ±0

Results for commit 4d76c0d. ± Comparison against base commit 1a76914.

♻️ This comment has been updated with latest results.

github-actions · 2022-02-22T13:26:03Z

Matrix SDK

Integration Tests Results:

[org.matrix.android.sdk.session]
passed=
[org.matrix.android.sdk.account]
passed=
[org.matrix.android.sdk.internal]
passed=
[org.matrix.android.sdk.ordering]
passed=
[org.matrix.android.sdk.PermalinkParserTest]
passed=

bmarty

That's a huge PR. I have only 1 quick remark.
I would defer to @ganfra for a review about the change SDK side.

bmarty · 2022-02-24T13:56:53Z

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/util/MatrixItem.kt

@@ -199,6 +200,8 @@ fun RoomMemberSummary.toMatrixItem() = MatrixItem.UserItem(userId, displayName,

 fun SenderInfo.toMatrixItem() = MatrixItem.UserItem(userId, disambiguatedDisplayName, avatarUrl)

+fun SenderInfo.toMatrixItemOrNull() = tryOrNull {  MatrixItem.UserItem(userId, disambiguatedDisplayName, avatarUrl) }


Weird, what was the problem with SenderInfo.toMatrixItem() ?

It was really rare but sometimes something was wrong with the servers userId (from a local homeserver). Null Check fixed the issue.

protected fun checkId() { if (!id.startsWith(getIdPrefix())) { error("Wrong usage of MatrixItem: check the id $id should start with ${getIdPrefix()}") } }

I do not really like this change TBH...

is the change something we could avoid by updating the local synapse script? (assuming live homeservers can't encounter the same problem)

bmarty · 2022-02-24T13:59:26Z

vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt

+            }
+        }
+        elementRobot.toggleLabFeature(LabFeature.THREAD_MESSAGES)
+    }


Thanks for adding a test here!

...roid/src/main/java/org/matrix/android/sdk/internal/database/migration/MigrateSessionTo026.kt

ganfra

Nice work! Some remarks/questions

...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/threads/ThreadsService.kt

...ava/org/matrix/android/sdk/internal/session/room/relation/threads/FetchThreadTimelineTask.kt

.../src/main/java/org/matrix/android/sdk/internal/session/room/timeline/LoadTimelineStrategy.kt

…ions api

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/relation/threads/FetchThreadTimelineTask.kt # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt

Enhance thread awareness handler so normal replies with thread disabled will be visible in te appropriate thread Fix conflicts

bmarty

Some more remarks, else LGTM.
We should probably merge this this week to be able to test a bit before the next release.

bmarty · 2022-03-10T20:05:36Z

...roid/src/main/java/org/matrix/android/sdk/api/session/room/model/relation/RelationContent.kt

@@ -24,4 +24,5 @@ interface RelationContent {
    val eventId: String?
    val inReplyTo: ReplyToContent?
    val option: Int?
+    val isFallingBack: Boolean? // Thread fallback to differentiate replies within threads


On the form I would use a javadoc. I do not like comment after the code

So something like

/** * doc... */ val isFallingBack: Boolean?

-> more readable and better integration with the IDE.

Also can you document a bit more what is the purpose of this val? What value true or false mean for this boolean? I have to confess that the name isFallingBack means nothing to me.

This flag, was a last minute change that I was not aware about. More details are here. I will add a more precise comment

...k-android/src/main/java/org/matrix/android/sdk/internal/session/room/relation/EventEditor.kt

ouchadam

awesome stuff! 👍 for merging and testing on develop

# Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/format/DisplayableEventFormatter.kt

Changes are applied, and we need to merge the feature

ariskotsomitopoulos added 14 commits February 14, 2022 15:09

- Integrate /relations API to create a live thread timeline

49b7726

format ktlint

83d937b

Merge branch 'develop' into feature/aris/threads_live_timeline

f1b11df

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt

Fix realm migration

27bc43c

Merge branch 'develop' into feature/aris/threads_live_timeline

f98b595

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/migration/MigrateSessionTo025.kt

Fix realm migration from 25 to 26

e9e5d68

format ktlint

830c38f

Introduce live thread summaries using the enhanced /messages API from…

83088bb

… MSC 3440 Add capabilities to support local thread list to not supported servers

Improve home server capabilities for threads

f4f48b9

Implement permalink support for /relations live thread timeline

2b740a1

Ktlint format

0f721d9

Merge branch 'develop' into feature/aris/thread_live_thread_list

79a231f

# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt

Resolve real migration conflicts

deb86d2

Resolve realm migration conflicts

9953d0d

ariskotsomitopoulos added 6 commits February 22, 2022 17:41

Fix quality check errors

2054c57

Fix wrong copyrights

f7f363c

Formating code

79c97ac

Add changelogs

a9b3882

Add new use case about threads in the allScreensTest

8788fb9

Merge branch 'develop' into feature/aris/thread_live_thread_list

8b25421

bmarty reviewed Feb 24, 2022

View reviewed changes

bmarty requested a review from ganfra February 24, 2022 14:00

Remove fetching thread summaries when homeserver do not support MSC3440

eda723c

ariskotsomitopoulos mentioned this pull request Feb 28, 2022

Feature/aris/threads analytics #5378

Merged

ouchadam reviewed Feb 28, 2022

View reviewed changes

...roid/src/main/java/org/matrix/android/sdk/internal/database/migration/MigrateSessionTo026.kt Show resolved Hide resolved

Add Markdown support to thread summaries and thread list

214e0ef

ganfra previously requested changes Mar 3, 2022

View reviewed changes

force refresh home server capabilities

33b1700

ariskotsomitopoulos requested a review from ganfra March 8, 2022 08:15

ariskotsomitopoulos added 6 commits March 8, 2022 14:50

Fix reply within thread edition

8c6902a

Remove eventType from /relations api for threads

a53d5bd

Remove io.element.thread and add stable m.thread prefix

03f293f

Check if the server supports MSC3440 using the stable flag from /vers…

45ee9f8

…ions api

Fix line length

fd30d38

This was linked to issues Mar 10, 2022

Cannot reply and edit message in a thread #5238

Closed

Threads: Update property stable values #5364

Closed

Add m.thread support after matrix.org backend release #5478

Closed

ariskotsomitopoulos removed a link to an issue Mar 10, 2022

Add m.thread support after matrix.org backend release #5478

Closed

This was linked to issues Mar 10, 2022

Threads: update m.render to m.display_reply_fallback #5363

Closed

Fix rendering of content types and formatting styles in root messages and thread summaries #5139

Closed

ariskotsomitopoulos added 3 commits March 10, 2022 17:51

Add is_falling_back support for rich thread replies

a758ad7

Enhance thread awareness handler so normal replies with thread disabled will be visible in te appropriate thread Fix conflicts

Merge branch 'develop' into feature/aris/thread_live_thread_list

34cfdfb

Fix unit tests

f31b130

bmarty approved these changes Mar 10, 2022

View reviewed changes

ariskotsomitopoulos added 4 commits March 14, 2022 11:54

Add more clear documentation

c2ec7cf

Merge branch 'develop' into feature/aris/thread_live_thread_list

d215f03

Temporarily fix develop crash

fef36d9

Format text

d894d85

ouchadam approved these changes Mar 14, 2022

View reviewed changes

ariskotsomitopoulos added 2 commits March 14, 2022 16:04

Add fallback support rendering proposed in MSC3676

d7c486c

Revert temporary fix for develop crash

c9f0706

ariskotsomitopoulos removed the request for review from ganfra March 15, 2022 10:28

Merge branch 'develop' into feature/aris/thread_live_thread_list

8a862d0

# Conflicts: # vector/src/main/java/im/vector/app/features/home/room/detail/timeline/format/DisplayableEventFormatter.kt

Fix build error

4d76c0d

ariskotsomitopoulos merged commit e0b93c2 into develop Mar 15, 2022

ariskotsomitopoulos deleted the feature/aris/thread_live_thread_list branch March 15, 2022 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Live Threads #5298

Live Threads #5298

ariskotsomitopoulos commented Feb 22, 2022 •

edited by bmarty

Loading

github-actions bot commented Feb 22, 2022 •

edited

Loading

github-actions bot commented Feb 22, 2022

bmarty left a comment

bmarty Feb 24, 2022

ariskotsomitopoulos Feb 28, 2022

bmarty Mar 10, 2022

ouchadam Mar 10, 2022 •

edited

Loading

bmarty Feb 24, 2022

ganfra left a comment

bmarty left a comment

bmarty Mar 10, 2022

ariskotsomitopoulos Mar 14, 2022

ouchadam left a comment

		@@ -199,6 +200,8 @@ fun RoomMemberSummary.toMatrixItem() = MatrixItem.UserItem(userId, displayName,

		fun SenderInfo.toMatrixItem() = MatrixItem.UserItem(userId, disambiguatedDisplayName, avatarUrl)

		fun SenderInfo.toMatrixItemOrNull() = tryOrNull { MatrixItem.UserItem(userId, disambiguatedDisplayName, avatarUrl) }

Live Threads #5298

Live Threads #5298

Conversation

ariskotsomitopoulos commented Feb 22, 2022 • edited by bmarty Loading

Live Thread Summaries

Live Thread Timeline

Home Server Capabilities for threads

github-actions bot commented Feb 22, 2022 • edited Loading

Unit Test Results

github-actions bot commented Feb 22, 2022

Matrix SDK

Integration Tests Results:

bmarty left a comment

Choose a reason for hiding this comment

bmarty Feb 24, 2022

Choose a reason for hiding this comment

ariskotsomitopoulos Feb 28, 2022

Choose a reason for hiding this comment

bmarty Mar 10, 2022

Choose a reason for hiding this comment

ouchadam Mar 10, 2022 • edited Loading

Choose a reason for hiding this comment

bmarty Feb 24, 2022

Choose a reason for hiding this comment

ganfra left a comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty Mar 10, 2022

Choose a reason for hiding this comment

ariskotsomitopoulos Mar 14, 2022

Choose a reason for hiding this comment

ouchadam left a comment

Choose a reason for hiding this comment

ariskotsomitopoulos commented Feb 22, 2022 •

edited by bmarty

Loading

github-actions bot commented Feb 22, 2022 •

edited

Loading

ouchadam Mar 10, 2022 •

edited

Loading