Feature/aris/threads analytics #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/threads_analytics
…/threads_analytics # Conflicts: # vector/src/main/java/im/vector/app/features/analytics/plan/Interaction.kt
…/threads_analytics
ouchadam
reviewed
Mar 16, 2022
| @@ -188,6 +189,9 @@ class MessageComposerViewModel @AssistedInject constructor( | |||
|
|
|||
| private fun handleSendMessage(action: MessageComposerAction.SendMessage) { | |||
| withState { state -> | |||
| analyticsTracker.capture(state.toAnalyticsComposer()).also { | |||
| setState { copy(startsThread = false) } | |||
There was a problem hiding this comment.
I'm wondering if there's a way to avoid this mutable state but I guess we need to be sure we only track the first message
ouchadam
reviewed
Mar 16, 2022
| import im.vector.app.features.home.room.detail.composer.MessageComposerViewState | ||
| import im.vector.app.features.home.room.detail.composer.SendMode | ||
|
|
||
| fun MessageComposerViewState.toAnalyticsComposer(): Composer = |
There was a problem hiding this comment.
tiny formatting comment (ideally the formatter would do this for us), the kotlin convention is typically to move the closing ) to a new line
fun MessageComposerViewState.toAnalyticsComposer() = Composer(
inThread = isInThreadTimeline(),
isEditing = sendMode is SendMode.Edit,
isReply = sendMode is SendMode.Reply,
startsThread = startsThread
)
ouchadam
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
LGTM! some tiny comments on formatting (until we have a way to enforce a convention or written examples it's not a blocker for me, but would be great to update)
will leave merging up to you @ariskotsomitopoulos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add analytics support for threads and closes #4910
Note: This PR requires Live Threads PR to be merged first, let's make this PR draft until we merge the prerequisite PR