Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In development release notes category #4953

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Jan 14, 2022

Adds a new release notes category for in development code changes, this will help ensure all code changes can be related back to a release even if they're not user facing at the time of merge.

  • Includes recently merged in development PRs
Draft output

Changes in Element 1 (2022-01-14)

Features ✨

  • Enabling native support for window resizing (#4811)

Bugfixes 🐛

  • Fix for stuck local event messages at the bottom of the screen (#516)
  • Explore Rooms overflow menu - content update include "Create room" (#3932)
  • Fix a wrong network error issue in the Legals screen (#4935)

In development 🚧

  • Disabling onboarding automatic carousel transitions on user interaction (#4914)
  • Locking phones to portrait during the FTUE onboarding (#4918)
  • Adds a messaging use case screen to the FTUE onboarding (#4927)

SDK API changes ⚠️

  • StateService.sendStateEvent() now takes a non-nullable String for the parameter stateKey. If null was used, just now use an empty string. (#4895)

Other changes

  • Fix integration tests and add a comment with results (still not perfect due to github actions resource limitations) (#4842)
  • "/kick" command is replaced with "/remove". Also replaced all occurrences in string resources (#4865)
  • Add signing config for the release buildType. No secret added (#4926)

- the aim is to link  merged PRs to WIP features so that every change is traceable to every release
CONTRIBUTING.md Outdated
@@ -61,6 +61,7 @@ Supported filename extensions are:

- ``.feature``: Signifying a new feature in Element Android or in the Matrix SDK.
- ``.bugfix``: Signifying a bug fix.
- ``.dev``: Signifying a change which is not ready to be user facing, typically a component of a larger feature.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if .dev is the best extension might be a little too generic, what do people think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe .wip since it's just an internal choose?

Copy link
Contributor Author

@ouchadam ouchadam Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me 👍
37aadf4

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

Unit Test Results

  66 files  ±0    66 suites  ±0   55s ⏱️ -3s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7259324. ± Comparison against base commit 31e487b.

♻️ This comment has been updated with latest results.

CONTRIBUTING.md Outdated
@@ -61,6 +61,7 @@ Supported filename extensions are:

- ``.feature``: Signifying a new feature in Element Android or in the Matrix SDK.
- ``.bugfix``: Signifying a bug fix.
- ``.dev``: Signifying a change which is not ready to be user facing, typically a component of a larger feature.
- ``.doc``: Signifying a documentation improvement.
- ``.removal``: Signifying a deprecation or removal of public API. Can be used to notifying about API change in the Matrix SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe take the opportunity to create a .sdk extension, this one is not obvious at first sight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to replace .removal with .sdk?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.removal is available out of the box, so I decided to hack it and use it to log the SDK change (especially in the API). Maybe just add .sdk and start using it is enough. Also need to update https://github.com/vector-im/element-android/blob/main/towncrier.toml#L23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understood correctly 7259324

if we want to keep the removal category is there a preferred section title?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will stop using .removal

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="21" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="5" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.internal]
    passed="158" failures="12" errors="0" skipped="38"
  • [org.matrix.android.sdk.ordering]
    passed="16" failures="0" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="1" failures="1" errors="0" skipped="0"

@bmarty bmarty merged commit f025554 into develop Jan 14, 2022
@bmarty bmarty deleted the feature/adm/in-dev-category branch January 14, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants