Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message when joining room #4848

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Update error message when joining room #4848

merged 1 commit into from
Jan 4, 2022

Conversation

Claire1817
Copy link
Contributor

This was referenced Jan 4, 2022
Closed
Closed
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Unit Test Results

  66 files  ±0    66 suites  ±0   59s ⏱️ +9s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 63c63bc. ± Comparison against base commit 5340d16.

bmarty
bmarty approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bmarty bmarty merged commit ed00f9f into develop Jan 4, 2022
@bmarty bmarty deleted the cgizard/translate_error_message_joining_room branch January 4, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Claire1817 @bmarty