Fix unread messages indicator on room list if no messages #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Jan 4, 2022
| @@ -136,7 +136,7 @@ internal class RoomSummaryUpdater @Inject constructor( | |||
|
|
|||
| roomSummaryEntity.hasUnreadMessages = roomSummaryEntity.notificationCount > 0 || | |||
| // avoid this call if we are sure there are unread events | |||
| !isEventRead(realm.configuration, userId, roomId, latestPreviewableEvent?.eventId) | |||
| latestPreviewableEvent?.let { !isEventRead(realm.configuration, userId, roomId, it.eventId) } ?: false | |||
There was a problem hiding this comment.
This is fine, but I am wondering if you should rather return true instead of false at this place: https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/query/ReadQueries.kt#L31
There was a problem hiding this comment.
Nope, by default we should consider event as unread, it's safer
There was a problem hiding this comment.
as discussed with @ganfra let's keep it like that.
ganfra
approved these changes
Jan 4, 2022
bmarty
deleted the
feature/dla/fix-unread-message-indicator-no-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no messages in a room lastPreviewableEvent will be null. We should not indicate there is an unread if we don't have a lastPreviewableEvent.
Fixes #4749