Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning logging for call selection #4637

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Fix warning logging for call selection #4637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d6fd7
state can also be connected
langleyd Dec 6, 2021
03be698
Fix waring for state is not dialing or connected
langleyd Dec 6, 2021
747030b
use != rather that is
langleyd Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/4636.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update log warning for call selection during voip calls.
4 changes: 2 additions & 2 deletions ...dk-android/src/main/java/org/matrix/android/sdk/internal/session/call/model/MxCallImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ internal class MxCallImpl(
Timber.tag(loggerTag.value).v("select answer $callId")
if (!isOutgoing) return
// This is an outgoing call, select the remote client that answered.
if (state != CallState.Dialing) {
Timber.tag(loggerTag.value).w("Expected state is CallState.Dialing got $state.")
if (state != CallState.Dialing && state !is CallState.Connected) {
Timber.tag(loggerTag.value).w("Expected state is CallState.Dialing or CallState.Connected got $state.")
}
CallSelectAnswerContent(
callId = callId,
Expand Down