Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning logging for call selection #4637

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Fix warning logging for call selection #4637

merged 3 commits into from
Dec 6, 2021

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Dec 6, 2021 •
edited
Loading

Fixes #4636

@langleyd langleyd requested a review from bmarty December 6, 2021 13:48
@langleyd langleyd self-assigned this Dec 6, 2021
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

Unit Test Results

  66 files  ±0    66 suites  ±0   48s ⏱️ -5s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 747030b. ± Comparison against base commit 88605b6.

♻️ This comment has been updated with latest results.

ouchadam
ouchadam approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

bmarty
bmarty approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bmarty bmarty merged commit f1d8b9e into develop Dec 6, 2021
@bmarty bmarty deleted the feature/dla/outgoing_pstn_call_fails branch December 6, 2021 20:37
@langleyd langleyd changed the title Feature/dla/outgoing pstn call fails Fix warning logging for call selection Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ouchadam ouchadam ouchadam approved these changes

Assignees

@langleyd langleyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix logging for callSelect
3 participants
@langleyd @ouchadam @bmarty