Adding support for voice drafts #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
commented
Nov 24, 2021
| data class Quote(val linkedEventId: String, val content: String) : UserDraft | ||
| data class Edit(val linkedEventId: String, val content: String) : UserDraft | ||
| data class Reply(val linkedEventId: String, val content: String) : UserDraft | ||
| data class Voice(val content: String) : UserDraft |
There was a problem hiding this comment.
Voice has been added, the other diff changes are caused by text being renamed to content
ouchadam
commented
Nov 24, 2021
| private fun handlePauseRecordingVoiceMessage() { | ||
| voiceMessageHelper.pauseRecording() | ||
| } | ||
|
|
||
| private fun handleEntersBackground(composerText: String) { | ||
| val isVoiceRecording = com.airbnb.mvrx.withState(this) { it.isVoiceRecording } |
There was a problem hiding this comment.
we want the synchronous state reading here as we need to act during onPause and clear any view state (clearTracker) whilst on the main thread
if we do this async then we can end up removing the waveforms due to clearTracker triggering after the reinitialising the views
- introduces a new Voice draft and sender mode type - initializes the voice recorder with a previously recorded file (the draft) - renames RecordingUiStates to map to their actual UI states
ouchadam
force-pushed
the
feature/adm/voice-draft
branch
from
c69fa49 to
aaba628
Compare
bmarty
approved these changes
Nov 30, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3922 Continuation of @onurays #4237 rebased and squashed with all of the refactors around the
VoiceMessageRecorderViewandMessageComposerViewModelrefactors (and also #4527)UserDraft.VoiceandSendMode.Voicein order to differentiate between audio messagesVoiceRecordingViewcallbacks to have explicit actions instead of exposing internalRecordingUiStates