Voice Message - Draft support #4237

onurays · 2021-10-13T13:29:54Z

If a user leaves the room detail screen without sending or deleting the ongoing voice message record then we need to save this record as a draft message and render it again in playback mode when the user enters the room detail screen again.

Extend the draft service to support multiple message types
Listen onPause of the RoomDetailFragment and save the VM draft if the recording is active
Show voice message in playback mode
Initialize voice message view with the saved draft
Delete the cache file if the user decides to delete or send the recording

EDIT
Fixes #3922

github-actions · 2021-10-13T14:03:31Z

Unit Test Results

  62 files ±0   62 suites ±0 58s ⏱️ +7s
118 tests ±0 118 ✔️ ±0 0 💤 ±0 0 ❌ ±0
350 runs ±0 350 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 5cb49ea. ± Comparison against base commit 0d6e8bd.

♻️ This comment has been updated with latest results.

bmarty · 2021-10-14T10:04:37Z

LGTM so far

bmarty

Thanks for your work.
Some first small remarks, will test it later.

bmarty · 2021-10-21T19:01:16Z

vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailFragment.kt

-        views.composerLayout.collapse()
-        views.composerLayout.setTextIfDifferent(text)
-        views.composerLayout.views.sendButton.contentDescription = getString(R.string.send)
+    private fun renderRegularMode(content: String, messageType: String) {


The body content does not match the name of this fun anymore.
Is it possible to not change this fun and create a new one like renderVoiceMessageMode()?
And test the value of messageType at the call site.

bmarty · 2021-10-21T19:02:38Z

vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailFragment.kt

-        // We should improve the UX to support going into playback mode when paused and delete the media when the view is destroyed.
-        roomDetailViewModel.handle(RoomDetailAction.EndAllVoiceActions(deleteRecord = false))
-        views.voiceMessageRecorderView.initVoiceRecordingViews()
+        roomDetailViewModel.handle(


We do not talk to the textComposerViewModel anymore here?

roomDetailViewModel will decide it and communicate with textComposerViewModel later with SaveDraft event.

bmarty · 2021-10-21T19:04:12Z

vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailFragment.kt

-        views.voiceMessageRecorderView.initVoiceRecordingViews()
+        roomDetailViewModel.handle(
+                RoomDetailAction.OnRoomDetailEntersBackground(
+                        isVoiceMessageActive = views.voiceMessageRecorderView.isActive()


It is strange to ask the view about the state. The ViewModel should be aware of the current state.

I found it complex to determine the state here, especially if there is already a draft in the room.

bmarty · 2021-10-21T19:08:47Z

vector/src/main/java/im/vector/app/features/voice/AbstractVoiceRecorder.kt

    override fun startRecord() {
        init()
-        outputFile = File(outputDirectory, "Voice message.$filenameExt")
+        val fileName = """${UUID.randomUUID()}.$filenameExt"""


The filename can be visible to the user, it will be a bit weird.
Is it possible to create a folder per room?
Also saving voice message draft could be handled by the Matrix SDK, using the DraftService

I proposed a way to keep drafts in a roomId based directory structure.

bmarty

LGTM, thanks!

bmarty · 2021-10-25T13:05:39Z

CI is not happy, can you handle that please? Thanks

bmarty · 2021-11-04T09:45:02Z

...android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt

+                ?.transform {
+                    it.setString(DraftEntityFields.MESSAGE_TYPE, MessageType.MSGTYPE_TEXT)
+                }
+


This will be a problem for those who are already on version 19. In this case you should create a version 20.

bmarty

I'm sorry I think this has to be modified.
I would like the voice messages to be saved as draft by the SDK, using DraftService.
It will simplify the code I think and make it more robust, by following our current architecture.
What do you think about it?

ouchadam · 2021-11-09T15:25:39Z

@bmarty from my understanding we are storing the draft via the DraftService https://github.com/vector-im/element-android/pull/4237/files#diff-40c47fd843620c38e4415e5731d825aaacf4d74d6e400cc9b573409fa550392dR604

I'm unfamiliar with the area, do you have more insight into the type of change you're expecting?

bmarty · 2021-11-10T09:19:53Z

vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewModel.kt

+            val audioJsonString = audioType?.toContentAttachmentData()?.toJsonString()
+            _viewEvents.post(RoomDetailViewEvents.SaveDraft(audioJsonString, MessageType.MSGTYPE_AUDIO))
+        } else {
+            _viewEvents.post(RoomDetailViewEvents.SaveDraft(null, MessageType.MSGTYPE_TEXT))


ouchadam · 2021-11-10T10:21:01Z

going to close this PR whilst working on it

Extend DraftEntity to be able to handle multiple message types.

b356a5c

Onuray Sahin added 5 commits October 14, 2021 13:14

Fix draft entity migration.

950c6f2

Save draft with message type.

67f25d1

Render draft message.

b54079a

Do not create redundant temp files.

2e078ca

Changelog added.

139c2bf

onurays requested a review from bmarty October 21, 2021 10:59

onurays marked this pull request as ready for review October 21, 2021 11:16

bmarty reviewed Oct 21, 2021

View reviewed changes

Code review fixes.

26713c4

bmarty approved these changes Oct 25, 2021

View reviewed changes

Merge branch 'develop' into feature/ons/voice_message_draft

5cb49ea

bmarty reviewed Nov 4, 2021

View reviewed changes

bmarty requested changes Nov 4, 2021

View reviewed changes

ouchadam self-assigned this Nov 9, 2021

bmarty reviewed Nov 10, 2021

View reviewed changes

ouchadam closed this Nov 10, 2021

This was referenced Nov 18, 2021

Voice recording UI state in ViewModel #4515

Merged

Voice Draft support #4527

Closed

Adding support for voice drafts #4558

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voice Message - Draft support #4237

Voice Message - Draft support #4237

onurays commented Oct 13, 2021 •

edited by bmarty

Loading

github-actions bot commented Oct 13, 2021 •

edited

Loading

bmarty commented Oct 14, 2021

bmarty left a comment

bmarty Oct 21, 2021

onurays Nov 1, 2021

bmarty Oct 21, 2021

onurays Oct 22, 2021

bmarty Oct 25, 2021

bmarty Oct 21, 2021

onurays Oct 25, 2021

bmarty Oct 21, 2021

onurays Oct 25, 2021

bmarty left a comment

bmarty commented Oct 25, 2021

bmarty Nov 4, 2021

bmarty left a comment

ouchadam commented Nov 9, 2021

bmarty Nov 10, 2021

ouchadam commented Nov 10, 2021

Voice Message - Draft support #4237

Voice Message - Draft support #4237

Conversation

onurays commented Oct 13, 2021 • edited by bmarty Loading

github-actions bot commented Oct 13, 2021 • edited Loading

Unit Test Results

bmarty commented Oct 14, 2021

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty commented Oct 25, 2021

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

ouchadam commented Nov 9, 2021

Choose a reason for hiding this comment

ouchadam commented Nov 10, 2021

onurays commented Oct 13, 2021 •

edited by bmarty

Loading

github-actions bot commented Oct 13, 2021 •

edited

Loading