Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invite by email screen in create space flow #3976

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Add invite by email screen in create space flow #3976

merged 3 commits into from
Sep 14, 2021

Conversation

BillCarsonFr
Copy link
Member

Fixes #3678 (add invite by mail screen for private space)
Fixes #3945 Remove the "Teammate spaces aren't quite ready" bottom sheet

When creating a new private team space, a screen is added where you can add up tp 3 emails. There is no integration with contact book for now.

  • If no emails entered you can skip this step
  • If one the email is malformed an inline error is displayed and you have to fix in order to continue
  • If no Identity Server is defined, user will see a message and an action to open discovery settings

image

image

image

@BillCarsonFr BillCarsonFr requested a review from bmarty September 7, 2021 12:27
@BillCarsonFr BillCarsonFr added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Sep 7, 2021
@BillCarsonFr
Copy link
Member Author

Full flow when you don't have IDS
image

@BillCarsonFr BillCarsonFr added the A-Spaces Spaces, groups, communities label Sep 8, 2021
bmarty
bmarty requested changes Sep 8, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(static review) 2 small remarks

vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceAdd3pidInvitesFragment.kt
super.onViewCreated(view, savedInstanceState)

views.recyclerView.configureWith(epoxyController)
epoxyController.listener = this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add cleanup in onDestroyView()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt Outdated
}

private fun stopListenToIdentityManager() {
identityService.addListener(identityServerManagerListener)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeListener :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

bmarty
bmarty approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@bmarty bmarty merged commit 3575157 into develop Sep 14, 2021
@bmarty bmarty deleted the feature/bca/space_team_invite_mail branch September 14, 2021 18:18
@BillCarsonFr BillCarsonFr mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
2 participants
@BillCarsonFr @bmarty