Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing "invite to space by email" behaviour when no identity server set #19052

Open
afranke opened this issue Sep 15, 2021 · 9 comments
Open
Labels
A-3PIDs A-Identity-Server A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@afranke
Copy link
Contributor

afranke commented Sep 15, 2021

Steps to reproduce

In a public space which I created, I click the Invite button, then type in an email address.

What happened?

I got the following error:

image

Operating system

Fedora 34

Browser information

Firefox 92

URL for webapp

app.element.io

Homeserver

matrix.org

Have you submitted a rageshake?

No

@SimonBrandner SimonBrandner added A-3PIDs A-Invite A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 15, 2021
@kittykat kittykat added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 15, 2021
@kittykat
Copy link
Contributor

Apparently updated templates for sydent were deployed earlier today (invites over email should now note whether you were invited to a room or a space) so probably related

@clokep
Copy link

clokep commented Sep 15, 2021

@kittykat @afranke Could you try this again? A couple members of the backend team looked into this and it seems everything is working from our side (and our tests worked fine).

@afranke
Copy link
Contributor Author

afranke commented Sep 15, 2021

Retried, got the same error as above.

@afranke
Copy link
Contributor Author

afranke commented Sep 15, 2021

When retrying again after I cleared the cache, I actually took the time to read the UI and

image

tells me I need an identity server (and I don’t have one for this account). So that’s fair… but it should be more obvious that it won’t work.

Please:

  • prevent me from “sending invites” if it’s not actually going to send invites
  • make the “identity server” words a link to an explanation of what it is and a way to add one.

@afranke afranke changed the title Can’t invite to space by email Confusing "invite to space by email" behaviour when no identity server set Sep 15, 2021
@novocaine novocaine added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 15, 2021
@BillCarsonFr
Copy link
Member

For reference element-hq/element-android#3976

@t3chguy t3chguy removed the A-Spaces Spaces, groups, communities label Sep 16, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 16, 2021

This dialog is for both spaces and rooms so not Spaces-specific.

@reivilibre
Copy link
Contributor

When I typed in an e-mail address in EleWeb to invite, as soon as I finished typing the domain name, it seemed to realise it was an e-mail address and then popped up the Identity server consent form.

Did you also see this?

(I notice if I disconnect from an identity server, then try again, this form doesn't pop up. Perhaps that's what you've done? I guess I must have had the identity server configured before and that was the first time I used it?)

@afranke
Copy link
Contributor Author

afranke commented Sep 16, 2021

As soon as I start typing something, a message appears below the entry.

image

So there is the link I was asking for (and it was actually already visible in my previous screenshot). However, it appears regardless of what I type, so even if the messages states it’s for email, it’s not obvious. The message also doesn’t tell me that I don’t have one configured and that the invite won’t work. It just tells me that one is required.

No consent dialog popped up. I never set up any identity server. It is possible though that I was asked for consent in the past and didn’t approve.

@kittykat kittykat added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 16, 2021
@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

As soon as I entered an e-mail address into the invite modal I was prompted to agree to use the default IS:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-3PIDs A-Identity-Server A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

9 participants