Room setting: improve room history and add join rule #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
force-pushed
the
feature/bma/room_history_join_rule
branch
from
a76ca6a to
b94d682
Compare
And observe correctly the state event
Including a reusable bottom sheet pattern, for future join rules setting bottom sheet
bmarty
force-pushed
the
feature/bma/room_history_join_rule
branch
from
b94d682 to
c785ea6
Compare
ganfra
approved these changes
Dec 1, 2020
| return taskExecutor.executorScope.launchToCallback(coroutineDispatchers.main, callback) { | ||
| if (joinRules != null) { | ||
| awaitCallback<Unit> { | ||
| sendStateEvent( |
There was a problem hiding this comment.
maybe create a private suspend sendStateEvent to avoid passing twice from callback to coroutine
There was a problem hiding this comment.
Thanks for the remark. This will be reworked when migrating this service API to coroutines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2442 and last part of #1579
This PR also fix some issue about the wording.
This PR introduces some parent classes to quickly implement a bottom sheet to make a choice between several possibilities.
Screenshot of the change