Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room alias missing features #1579

Closed
bmarty opened this issue Jun 30, 2020 · 1 comment · Fixed by #2439
Closed

Room alias missing features #1579

bmarty opened this issue Jun 30, 2020 · 1 comment · Fixed by #2439
Assignees
@bmarty
Labels
A-Aliases A-Room-Settings Z-parity-with-web
Milestone
Sprint 16

Comments

@bmarty
Copy link
Member

bmarty commented Jun 30, 2020 •
edited
Loading

#1464 starts the work on Room settings. What is missing:

  • removing alias
  • listing aliases
  • give user a chance to set canonical alias from the list

Also we may improve the room settings view state: add a data class to hold current room state, and update it when the state is changed.
Also setting the room history visibility (without saving) and reverting the change let the save button active (when we revert the change
@bmarty bmarty changed the title Room alias missing feature Room alias missing features Jun 30, 2020
@onurays onurays self-assigned this Jun 30, 2020
@bmarty bmarty assigned bmarty and unassigned onurays Nov 24, 2020
@bmarty bmarty added this to the Sprint 17 milestone Nov 24, 2020
@bmarty bmarty modified the milestones: Sprint 17, Sprint 16 Nov 24, 2020
@bmarty bmarty mentioned this issue Nov 24, 2020
Merged
bmarty added a commit that referenced this issue Nov 26, 2020
@bmarty
Improve room history visibility setting UX (#1579)
b679220 
And observe correctly the state event
@bmarty bmarty mentioned this issue Nov 26, 2020
Merged
bmarty added a commit that referenced this issue Nov 27, 2020
@bmarty
Improve room history visibility setting UX (#1579)
e1544cf 
And observe correctly the state event
bmarty added a commit that referenced this issue Nov 30, 2020
@bmarty
Improve room history visibility setting UX (#1579)
bb5d5ff 
And observe correctly the state event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Aliases A-Room-Settings Z-parity-with-web
Projects
None yet
Milestone
Sprint 16
Development

Successfully merging a pull request may close this issue.

Add room alias management element-hq/element-android
3 participants
@onurays @bmarty and others