-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rich text editor] Add inline code to rich text editor #8011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question about the usage of io.element.android.wysiwyg.EditorStyledTextView
.
@@ -7,7 +7,7 @@ | |||
android:orientation="vertical" | |||
tools:viewBindingIgnore="true"> | |||
|
|||
<TextView | |||
<io.element.android.wysiwyg.EditorStyledTextView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this will be used even if the lab flag is disabled for the rich text composer. Can it be an issue?
I mean if the app crashes because of io.element.android.wysiwyg.EditorStyledTextView
, the users will not be able to disable the lab flag to fallback to a stable version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated so that the text view class will depend on whether the rich text editor is enabled in Labs: 4107887
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
15e13a9
to
4107887
Compare
SonarCloud Quality Gate failed. |
Type of change
Content
Motivation and context
PSU-1069
Screenshots / GIFs
Timeline, with rich text editor enabled
Timeline, with rich text editor disabled
Inline code in the editor
editor.webm
Tests
Tested devices
Checklist