Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra new lines inserted in front of HTML inline code #423

Open
jonnyandrew opened this issue Jan 19, 2023 · 0 comments
Open

Extra new lines inserted in front of HTML inline code #423

jonnyandrew opened this issue Jan 19, 2023 · 0 comments
Labels

Comments

@jonnyandrew
Copy link

Markwon version: 4.6.2

Extra new lines are inserted in front of inline code while parsing HTML.

I have created a minimal reproduction of this bug here: jonnyandrew/markwon-repro.

Steps to reproduce

  1. Build Markwon with the HtmlPlugin.
  2. Parse a block e.g. markwon.parse("<div>block</div>")
  3. Render this block
  4. Parse some text with inline code e.g. markwon.parse("Some <code>inline code</code>")
  5. Render this text

Expected

The rendered text does not have any extra new lines.

Actual

The rendered text has a new line immediately before the inline code.

Screenshot from the repro app

image

jonnyandrew added a commit to element-hq/element-android that referenced this issue Jan 26, 2023
jonnyandrew added a commit to element-hq/element-android that referenced this issue Jan 30, 2023
jonnyandrew added a commit to element-hq/element-android that referenced this issue Feb 28, 2023
jonnyandrew added a commit to element-hq/element-android that referenced this issue Feb 28, 2023
jonnyandrew added a commit to element-hq/element-android that referenced this issue Mar 6, 2023
* Extend workaround for extra new lines in timeline

Closes #8179

Caused by noties/Markwon#423

* Refactor

Co-authored-by: Yoan Pintas <[email protected]>

---------

Co-authored-by: Yoan Pintas <[email protected]>
@noties noties added the bug label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants