Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick scrolling through timeline with m.notice messages causes some of them to suck surrounding regular messages into themselves #8443

Open
rom4nik opened this issue May 17, 2023 · 3 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@rom4nik
Copy link
Contributor

rom4nik commented May 17, 2023

Steps to reproduce

  1. Join a room with one or more m.notice messages present, such as #ping:maunium.net
  2. Send a regular text message (or have another user send it, as was the case in screenshots below)
  3. Scroll quickly through older messages in the room, making use of inertial scrolling
  4. After a few attempts one or more m.notice messages will pull one of regular messages into its body, rendered as if they were part of the same message bubble
  5. Long press the m.notice part of bubble and go to source - you'll see source of m.notice message
  6. Long press the regular message's text on the bubble and go to source - you'll see source of the regular message

This issue can be reproduced in other rooms too, but in the ping room it's easier to spot due to large amount of m.notices. It's been a problem on older app versions too, definitely on 1.5.32.

Outcome

What did you expect?

m.notices not sucking nearby regular messages into themselves.

What happened instead?

One of m.notices as displayed in timeline after a few seconds of scrolling up and down:
mpv-shot0001

The "Pong! (...)" response was sent by Ping [nevarro.space], "hyper test" was sent by "Hyperbot" in response to my "test" message.

Menu and message source after long press on "hyper test" text:
mpv-shot0002
mpv-shot0003

Menu and message source after long press on "Pong! (..)" text:
mpv-shot0004
mpv-shot0005

Your phone model

Google Pixel 3

Operating system version

Android 12

Application version and app store

Element 1.6.0 from .apk in GH releases

Homeserver

Synapse 1.83.0

Will you send logs?

Yes

Are you willing to provide a PR?

No

@rom4nik rom4nik added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 17, 2023
@rom4nik
Copy link
Contributor Author

rom4nik commented May 17, 2023

Rage shake sent for a similar case, this time messages from daedric were rendered with nearby m.notices sent by pong bots:

Screenshot_20230518-004125_Element

@jonnyandrew jonnyandrew added A-Timeline S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 19, 2023
@rom4nik
Copy link
Contributor Author

rom4nik commented Jun 8, 2023

I've noticed that this issue occurs only if rich text editor is enabled in Labs on EA versions >= 1.5.24.

@rom4nik
Copy link
Contributor Author

rom4nik commented Jun 8, 2023

This issue was introduced in 00f9c36 (#8011).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants