Create Avatar component #4
Conversation
| const imgCache = { | ||
| __cache: new Map<string, Promise<unknown> | boolean>(), | ||
| read(src: string): boolean { | ||
| if (!this.__cache.has(src)) { | ||
| // Create a cache entry with a promise to notify the image is still being loadedd | ||
| this.__cache.set( | ||
| src, | ||
| new Promise((resolve) => { | ||
| const img = new Image(); | ||
| img.onload = () => { | ||
| this.__cache.set(src, true); | ||
| resolve(this.__cache.get(src)); | ||
| }; | ||
| img.src = src; | ||
| }).then(() => { | ||
| this.__cache.set(src, true); | ||
| }) | ||
| ); | ||
| } | ||
| if (this.__cache.get(src) instanceof Promise) { | ||
| throw this.__cache.get(src); | ||
| } | ||
| return this.__cache.get(src) as boolean; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
As this considers an image, once it has loaded, cached forever, it might give false positives for images that have been evicted by the browser. On the other hand it might lead to a flash of the fallback image if the browser still has an image cached from a previous session. It also doesn't handle errors while loading images correctly yet.
Fine for now, but in the future, it might be ideal if we implement this in a better way.
| const MAX = 8; | ||
| // Sum up the values of all the char codes in the string | ||
| const charCodeSum = id.split("").reduce((sum, char) => { | ||
| return sum + char.charCodeAt(0); |
There was a problem hiding this comment.
Note that for names containing unicode characters outside the basic multilingual plane this will use the surrogate pairs. It relies on the specific UCS-2 16-bit encoding common to JS/Java/Windows/Qt
There was a problem hiding this comment.
As discussed with Janne, most of our codebase will use utf-8 and that shouldn't present a great threat.
There's also a chance that those colors would go away altogether.
We're punting this decision to a later stage
For element-hq/compound#117
For element-hq/compound#137
@janogarcia would you be able to provide me with 8 color codes for the username mapping?