Infer win32metadata from package.json/top-level options

[malept]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Closes #297.
Fixes #611.

[MarshallOfSound]

Was reading through this before you even summoned my review 👍 LGTM 🚢

[MarshallOfSound]

Actually hold up a second, just checking something

checking something

[MarshallOfSound]

After a quick check of 30 of my installed applications on my Windows machine 27 of them set FileDescription to be the same as ProductName and the other 3 are close just missing some symbols / spacing.

Perhaps it's worth reconsidering that default, not sure why but everyone else seems to be doing it 😕

(Even I'm doing it in GPMDP)

[develar]

Perhaps it's worth reconsidering that default, not sure why but everyone else seems to be doing it

Because on bloody windows FileDescription is used as app name in the process view. And if you will use description instead of name — you will get user reports. Details — electron-userland/electron-builder#965

[MarshallOfSound]

Haha, thanks @develar

That actually reminds me when I had that problem before... That's windows for ya... @malept should probably change it to be productName || name then 😄

[develar]

Be aware that you must normalise version string according to *** MS Windows requirements, otherwise Squirrel.Windows will be not happy and it can lead to crash — electron-userland/electron-builder#1101 (comment)

[malept]

If there aren't any more concerns about this PR, I'll merge it.