-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32metadata should have sensible defaults #611
Comments
I like this, I've been waiting for someone who has a Windows machine to write something that I can understand for sensible defaults for the metadata fields 😅 About |
I have Windows instances available so let me know if I can be any help. |
The person who implements this should use the |
win32metada
should have reasonable defaults so that Squirrel shortcut creation works out of the box as expected.Currently, https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#win32metadata defaults to an empty object AFAIK and therefore the default metadata from Electron is left intact.
This results in lots of questions like "Why is my Squirrel shortcut called 'Electron'?". This can be solved by simply providing logical defaults for the
win32metadata
option as follows below. Where "p" === "package.json"config.name or p.productName or p.name
config.name or p.productName or p.name
config.name or p.productName or p.name
p.description
p.author
This is just a proposal, feedback on this welcome 👍
The text was updated successfully, but these errors were encountered: