feat: Codesign all binary-like files #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethlu
commented
Jun 25, 2018
| return getFilePathIfBinaryAsync(filePath) | ||
| } // Else reject hidden file | ||
| break | ||
| case '.dylib': // Dynamic library |
There was a problem hiding this comment.
Still need to keep .dylib
There was a problem hiding this comment.
👌 The .dylib files should be detected as a binary file.
sethlu
force-pushed
the
codesign-all-binary-like-files
branch
from
170e8c0 to
533c752
Compare
sethlu
changed the title
sethlu
force-pushed
the
codesign-all-binary-like-files
branch
from
533c752 to
8c3e66a
Compare
|
We shouldn't need to worry about missing unsigned binary files now with this change merged in. |
|
@sethlu Does it take care of frameworks? Some native modules might have framework dependencies |
|
@vyunikov All frameworks ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, files with names like
.node(.nodeas the base name, not as a file extension) will be skipped while scanning the application bundle. Testing all possible binary files should help clear the naming ambiguity. Files like.gitignoreshould still be skipped.Addresses: #168
cc: @malept