Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Object files (*.so) Not automatically signed #226

Closed
Marcus10110 opened this issue Apr 17, 2020 · 2 comments
Closed

Shared Object files (*.so) Not automatically signed #226

Marcus10110 opened this issue Apr 17, 2020 · 2 comments

Comments

@Marcus10110
Copy link

The walkAsync function, which locates all files to sign, does not identify *.so files, however it does identify binary files, *.dylib, and *.node files.
https://github.com/electron/electron-osx-sign/blob/caef6a5893dc223d80b31f926c6ae2ebd62787c7/util.js#L229

*.so files are valid on MacOS, and we use them for plugins in our application.

I found this problem when trying to notarize our application. None of our so files were signed.

@sethlu
Copy link
Contributor

sethlu commented May 5, 2020

Hi @Marcus10110 thanks for filing this issue! This should be resolved with #169 😺
You can look forward to a new release later this week and the *.so files will be included automatically too.

@sethlu
Copy link
Contributor

sethlu commented May 23, 2020

Resolved in #169 and should be available in [email protected]
Thanks for opening the issue @Marcus10110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants