fix(publisher-github): don't reexport Octokit type #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-exporting TypeScript types results in broken JavaScript (the type doesn't exist in JS, resulting in a require error that's hidden by `@electron-forge/core`'s `require-search`).
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
=======================================
Coverage 72.68% 72.68%
=======================================
Files 74 74
Lines 2215 2215
Branches 419 419
=======================================
Hits 1610 1610
Misses 443 443
Partials 162 162
Continue to review full report at Codecov.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Re-exporting TypeScript types results in broken JavaScript (the type doesn't exist in JS, resulting in a require error that's hidden by
@electron-forge/core'srequire-search).Fixes #1951