Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find a publish target with the name: @electron-forge/publisher-github #1958

Closed
2 tasks done
chrubb opened this issue Sep 10, 2020 · 5 comments
Closed
2 tasks done
Labels

Comments

@chrubb
Copy link

chrubb commented Sep 10, 2020

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • [x ] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Forge Version:
    • 6.0.0-beta.53
  • Electron Version:
    • 10.1.1
  • Operating System:
    • Win10 2004 1904
  • Last Known Working Electron Forge version::
    • na

Expected Behavior

expect to be able to publish to github

Actual Behavior

publish fails with 'Could not find a publish target with the name: @electron-forge/publisher-github'

To Reproduce

follow steps in https://www.electronforge.io/getting started
add publisher to forge config as per https://www.electronforge.io/publishers/github
yarn run publish

Additional Information

i have checked global installs to ensure i am not running mixed versions of electron electron-forge etc.

so here is package config

"config": {
"forge": {
"packagerConfig": {},
"makers": [
{
"name": "@electron-forge/maker-squirrel",
"config": {
"name": "my_app"
}
},
{
"name": "@electron-forge/maker-zip",
"platforms": [
"darwin"
]
},
{
"name": "@electron-forge/maker-deb",
"config": {}
},
{
"name": "@electron-forge/maker-rpm",
"config": {}
}
],
"publishers": [
{
"name": "@electron-forge/publisher-github",
"config": {
"repository": {
"owner": "chrubb",
"name": "------"
},
"authToken": "--------------------------------------------",
"prerelease": "true"
}
}
]
}
},
"dependencies": {
"electron-squirrel-startup": "^1.0.0"
},
"devDependencies": {
"@electron-forge/cli": "6.0.0-beta.53",
"@electron-forge/maker-deb": "6.0.0-beta.53",
"@electron-forge/maker-rpm": "6.0.0-beta.53",
"@electron-forge/maker-squirrel": "6.0.0-beta.53",
"@electron-forge/maker-zip": "6.0.0-beta.53",
"@electron-forge/publisher-github": "^6.0.0-beta.53",
"electron": "10.1.1"
}

here is debug output

PS D:\GitHub\Repos\my-app> yarn run publish
yarn run v1.22.4
$ electron-forge publish
WARNING: DEBUG environment variable detected. Progress indicators will be sent over electron-forge:lifecycle
electron-forge:async-ora Process Started: Checking your system +0ms
electron-forge:check-system checking system, create ~/.skip-forge-system-check to stop doing this +0ms
electron-forge:async-ora Process Succeeded: Checking your system -- after 276ms +276ms
WARNING: DEBUG environment variable detected. Progress indicators will be sent over electron-forge:lifecycle
electron-forge:publish triggering make +0ms
electron-forge:async-ora Process Started: Resolving Forge Config +0ms
electron-forge:project-resolver searching for project in: D:\GitHub\Repos\my-app +0ms
electron-forge:project-resolver electron-forge compatible package.json found in D:\GitHub\Repos\my-app\package.json +26ms
electron-forge:async-ora Process Succeeded: Resolving Forge Config -- after 57ms +57ms
electron-forge:require-search searching [
'@electron-forge/maker-squirrel',
'D:\GitHub\Repos\my-app\@electron-forge\maker-squirrel',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\maker-squirrel'
] relative to D:\GitHub\Repos\my-app +0ms
electron-forge:require-search testing @electron-forge/maker-squirrel +86ms
electron-forge:require-search searching [
'@electron-forge/maker-zip',
'D:\GitHub\Repos\my-app\@electron-forge\maker-zip',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\maker-zip'
] relative to D:\GitHub\Repos\my-app +174ms
electron-forge:require-search testing @electron-forge/maker-zip +1ms
electron-forge:require-search searching [
'@electron-forge/maker-deb',
'D:\GitHub\Repos\my-app\@electron-forge\maker-deb',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\maker-deb'
] relative to D:\GitHub\Repos\my-app +3ms
electron-forge:require-search testing @electron-forge/maker-deb +1ms
electron-forge:require-search searching [
'@electron-forge/maker-rpm',
'D:\GitHub\Repos\my-app\@electron-forge\maker-rpm',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\maker-rpm'
] relative to D:\GitHub\Repos\my-app +3ms
electron-forge:require-search testing @electron-forge/maker-rpm +26ms
We need to package your application before we can make it
electron-forge:async-ora Process Started: Preparing to Package Application for arch: x64 +300ms
electron-forge:project-resolver searching for project in: D:\GitHub\Repos\my-app +332ms
electron-forge:project-resolver electron-forge compatible package.json found in D:\GitHub\Repos\my-app\package.json +1ms
electron-forge:packager packaging with options {
asar: false,
overwrite: true,
dir: 'D:\GitHub\Repos\my-app',
arch: 'x64',
platform: 'win32',
afterCopy: [ [AsyncFunction] ],
afterExtract: [ [AsyncFunction] ],
afterPrune: [ [AsyncFunction] ],
out: 'D:\GitHub\Repos\my-app\out',
electronVersion: '10.1.1',
quiet: true
} +0ms
electron-forge:async-ora Process Succeeded: Preparing to Package Application for arch: x64 -- after 3s +3s
electron-forge:async-ora Process Started: Preparing native dependencies +2ms
electron-forge:async-ora Process Succeeded: Preparing native dependencies -- after 55ms +55ms
electron-forge:async-ora Process Started: Packaging Application +1ms
electron-forge:async-ora Process Succeeded: Packaging Application -- after 1.9s +2s
Making for the following targets: squirrel
electron-forge:async-ora Process Started: Making for target: squirrel - On platform: win32 - For arch: x64 +2ms
electron-forge:async-ora Process Succeeded: Making for target: squirrel - On platform: win32 - For arch: x64 -- after 41.9s +42s
electron-forge:project-resolver searching for project in: D:\GitHub\Repos\my-app +47s
electron-forge:project-resolver electron-forge compatible package.json found in D:\GitHub\Repos\my-app\package.json +1ms
electron-forge:async-ora Process Started: Resolving publish target: @electron-forge/publisher-github +3ms
electron-forge:require-search searching [
'@electron-forge/publisher-github',
'D:\GitHub\Repos\my-app\@electron-forge\publisher-github',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\publisher-github'
] relative to D:\GitHub\Repos\my-app +47s
electron-forge:require-search testing @electron-forge/publisher-github +3ms
electron-forge:require-search testing D:\GitHub\Repos\my-app@electron-forge\publisher-github +49ms
electron-forge:require-search testing D:\GitHub\Repos\my-app\node_modules@electron-forge\publisher-github +1ms
electron-forge:require-search failed to find a module in [
'@electron-forge/publisher-github',
'D:\GitHub\Repos\my-app\@electron-forge\publisher-github',
'D:\GitHub\Repos\my-app\node_modules\@electron-forge\publisher-github'
] +2ms
electron-forge:async-ora Process Failed: Resolving publish target: @electron-forge/publisher-github -- after 83ms +84ms

An unhandled error has occurred inside Forge:
Could not find a publish target with the name: @electron-forge/publisher-github. Make sure it's listed in the devDependencies of your package.json
Error: Could not find a publish target with the name: @electron-forge/publisher-github. Make sure it's listed in the devDependencies of your package.json
at asyncFn (D:\GitHub\Repos\my-app\node_modules@electron-forge\core\src\api\publish.ts:170:17)
at D:\GitHub\Repos\my-app\node_modules@electron-forge\async-ora\src\ora-handler.ts:35:5
at new Promise ()
at asyncOra (D:\GitHub\Repos\my-app\node_modules@electron-forge\async-ora\src\ora-handler.ts:34:10)
at publish (D:\GitHub\Repos\my-app\node_modules@electron-forge\core\src\api\publish.ts:167:13)
at D:\GitHub\Repos\my-app\node_modules@electron-forge\cli\src\electron-forge-publish.ts:36:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

and yes, publisher-github is installed...

PS D:\GitHub\Repos\my-app> yarn list @electron-forge/publisher-github
yarn list v1.22.4
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ @electron-forge/[email protected]
Done in 0.37s.
PS D:\GitHub\Repos\my-app>

@chrubb chrubb added the bug label Sep 10, 2020
@tagus
Copy link

tagus commented Sep 13, 2020

I just ran into the same issue however temporarily reverting back to @electron-forge/[email protected] seems to be working.

@chrubb
Copy link
Author

chrubb commented Sep 14, 2020

interesting. I tried rolling back to beta.52 but it didnt make any difference. I have worked back through the releases from .50 to .53 and cannot see any reason for this - admittedly it was a pretty cursory look... Hopefully someone with a bit more in depth knowledge will be able to find something or at least point me in the right direction. In the meantime its back to manual publishing for a while i guess.

@malept
Copy link
Member

malept commented Sep 15, 2020

Fixed in #1962.

@jamland
Copy link

jamland commented Sep 27, 2020

Experiencing the same issue with 6.0.0-beta.53, tried also 6.0.0-beta.50 and 6.0.0-beta.52 with the same result (packages set in devDependencies).
Also, I was trying to recreate electron-forge project from scratch with the same result 🙁

@malept
Wondering, if this is fixed, should I do something additional to apply this fix or it will be shipped in the next release?

LOG:

... after notarizing the app successfully
...
Error: Could not find a publish target with the name: @electron-forge/publisher-github. Make sure it's listed in the devDependencies of your package.json
    at asyncFn (_my_project_/node_modules/@electron-forge/core/src/api/publish.ts:170:17)
    at _my_project_/node_modules/@electron-forge/async-ora/src/ora-handler.ts:35:5
    at new Promise (<anonymous>)
    at asyncOra (_my_project_/node_modules/@electron-forge/async-ora/src/ora-handler.ts:34:10)
    at publish (_my_project_/node_modules/@electron-forge/core/src/api/publish.ts:167:13)
    at _my_project_/node_modules/@electron-forge/cli/src/electron-forge-publish.ts:36:3

@jamland
Copy link

jamland commented Sep 28, 2020

I figured out how to fix it for my case. I had caret (^) in the package name.

"@electron-forge/publisher-github": "^6.0.0-beta.52"

So in a result npm was installing 6.0.0-beta.53 version anyway. It works well without caret (^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants