Drop Node 4 support #145
Merged
Drop Node 4 support #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per #96 (comment) `fs.ensureDir` has `mode` documented, as of jprichardson/node-fs-extra#587
fcastilloec
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
I'm glad to know that fs-extra has now added documentation for using mode. I've been waiting for so long that I forgot about it.
I think I mentioned previously that I'd like to add a package-lock.json to the project, mainly so when we test in the CIs, we use npm ci to always have consistent dependencies. This has nothing to do with the new release so it can be done later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops Node 4 support, updates all dependencies, and tests CI against Node 10.
Also replaces
mkdirpwithfs-extra's functionality, becausefs.ensureDirhasmodedocumented, as ofjprichardson/node-fs-extra#587
Once this PR is merged, I'll file the PR for 1.0.0 🎉