Removes Lintian warning and errors #96
Conversation
This will remove 'non-standard-dir-perm', 'non-standard-file-perm' and 'extra-license-file' from lintian
Permissions have been changed to all files inside "app with asar" in order to supress all lintian errors and warnings. There are still lintianOverrides but none related to file permissions
The deb packages where being deleted by mocha at the end of each test so lintian was not outputing anything. There's a test specific to lintian now
fcastilloec
force-pushed
the
lintian
branch
from
fb0a9ad to
1f4b49e
Compare
|
I have rebased my PR with all the latest commits. @malept or @unindented could you briefly check the code and either approve or request changes before I merge this request? |
.travis.yml
Outdated
| @@ -11,6 +11,7 @@ addons: | |||
| packages: | |||
| - fakeroot | |||
| - lintian | |||
| - fakeroot | |||
There was a problem hiding this comment.
Good catch, the result of rebasing and eslint doesn't check for this
| @@ -11,6 +11,7 @@ var glob = require('glob') | |||
| var path = require('path') | |||
| var temp = require('temp').track() | |||
| var wrap = require('word-wrap') | |||
| var mkdirp = require('mkdirp') | |||
There was a problem hiding this comment.
fs-extra already has this functionality (https://github.com/jprichardson/node-fs-extra/blob/master/docs/ensureDir.md), so no need to add more dependencies.
There was a problem hiding this comment.
Appears to be unofficially supported: jprichardson/node-fs-extra#60
There was a problem hiding this comment.
I guess when it becomes officially supported we can switch to using only fs-extra in the meantime we should stick with mkdirp
| async.apply(fs.symlink, binSrc, binDest, 'file') | ||
| ], function (err) { | ||
| callback(err && new Error('Error creating binary file: ' + (err.message || err))) | ||
| mkdirp(binDir, '0755', function (err, made) { |
There was a problem hiding this comment.
Ah, but fs-extra doesn't have chmod options. Oh well, another dependency it is then.
There was a problem hiding this comment.
Yes, we're going to need a new dependency until fs-extra decides to include chmod options to their commands
Per #96 (comment) `fs.ensureDir` has `mode` documented, as of jprichardson/node-fs-extra#587
The warnings
non-standard-dir-perm,non-standard-file-perm,extra-license-fileare addressed by this PR.As we stand, only
debian-changelog-file-missingandbinary-without-manpageare the only lintianOverrides needed. Any other warning or errors are related to the app being packaged and notelectron-installer-debianThe test provided uses
app-with-asarso there's only one file permission to worried. All files and directories permissions insideapp-with-asarhave been change from0664->0644and0775->0755. This change is in accordance with debian rules and will pass all lintian checks address by this PR.