Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scalable icons #104

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

fcastilloec
Copy link
Collaborator

This will address issue #94

@@ -331,7 +331,12 @@ var createPixmapIcon = function (options, dir, callback) {
*/
var createHicolorIcon = function (options, dir, callback) {
async.forEachOf(options.icon, function (icon, resolution, callback) {
var iconFile = path.join(dir, 'usr/share/icons/hicolor', resolution, 'apps', options.name + '.png')
var iconFile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should start using let.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I think that should be different PR since var is used everywhere right now

@fcastilloec
Copy link
Collaborator Author

If everything is fine with this PR can @malept approve it, unless there's something you need me to change

@fcastilloec fcastilloec merged commit c7ca620 into electron-userland:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants