Merge pull request #104 from fcastilloec/master

Add support for scalable icons
electron-userland · Sep 29, 2017 · c7ca620 · c7ca620
2 parents 8e98d66 + ece233e
commit c7ca620
Show file tree

Hide file tree

Showing 4 changed files with 76 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -357,10 +357,12 @@ Or multiple images with their corresponding resolutions:
     '48x48': 'resources/Icon48.png',
     '64x64': 'resources/Icon64.png',
     '128x128': 'resources/Icon128.png',
-    '256x256': 'resources/Icon256.png'
+    '256x256': 'resources/Icon256.png',
+    'scalable': 'resources/Icon.svg'
   }
 }
 ```
+Note that the image files must be one of the types: PNG or SVG. The support for SVG works only on `scalable` resolution.
 
 #### options.categories
 Type: `Array[String]`

diff --git a/src/installer.js b/src/installer.js
@@ -331,7 +331,12 @@ var createPixmapIcon = function (options, dir, callback) {
  */
 var createHicolorIcon = function (options, dir, callback) {
   async.forEachOf(options.icon, function (icon, resolution, callback) {
-    var iconFile = path.join(dir, 'usr/share/icons/hicolor', resolution, 'apps', options.name + '.png')
+    var iconFile
+    if (resolution === 'scalable') {
+      iconFile = path.join(dir, 'usr/share/icons/hicolor', resolution, 'apps', options.name + '.svg')
+    } else {
+      iconFile = path.join(dir, 'usr/share/icons/hicolor', resolution, 'apps', options.name + '.png')
+    }
     options.logger('Creating icon file at ' + iconFile)
 
     mkdirp(path.dirname(iconFile), '0755', function (err, made) {