This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
Handle unknown compilers nicer, fallback to passthrough #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaisbetts
reviewed
Jan 1, 2017
| @@ -239,7 +239,11 @@ export default class CompilerHost { | |||
| if (!compiler) { | |||
| compiler = this.fallbackCompiler; | |||
|
|
|||
| let { code, binaryData, mimeType } = await compiler.get(filePath); | |||
| if (!compiler) { | |||
| compiler = this.getPassthroughCompiler(); | |||
There was a problem hiding this comment.
I'm not sure that this is correct, for complicated weird reasons. Do you have a repro file that you hit this with?
There was a problem hiding this comment.
@paulcbetts I used this repo for repro
https://github.com/manikantag/electron-compile-css-issue
There was a problem hiding this comment.
Just running electron-forge package and then launching the packaged app
There was a problem hiding this comment.
Cool. Imma fix this today
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes electron/forge/issues/53