Problem with non minified CSS files

[manikantag]

I m not sure if this is really a electron-forge issue, as I doubt this is an issue with electron-compile itself. But anyway I wanted to confirm.

Please describe your issue:
Non minified CSS files not being loaded properly after package/make. Same are working fine with electron-forge start. And if I use minified CSS files, they are working with package/make too.

Please see this repo to reproduce the issue: https://github.com/manikantag/electron-compile-css-issue

electron-forge start --> will start the app and text will be blinking.
electron-forge package --> open the electron-forge-demo\out\electron-forge-demo-win32-x64\electron-forge-demo.exe file. App will be opened, but text will not be bliking and in the devtools network tab you can something similar to below one.

Use the min.css (https://github.com/manikantag/electron-compile-css-issue/blob/master/src/index.html#L7) and run the electron-forge package and this time text blinks (-> CSS file loaded correctly).

[manikantag]

@MarshallOfSound I feel this is similar to the issue I've reported here electron-userland/electron-compile#61 (comment)

[malept]

If you look at the error you get in the devtools pane, it's clear that the error is caused by electron-compile. Here's the error in full, when I run it:

Failed to compile /tmp/electron-compile-css-issue/out/electron-forge-demo-linux-x64/resources/app/src/css/app.css: Cannot read property 'get' of null
TypeError: Cannot read property 'get' of null
    at /tmp/electron-compile-css-issue/out/electron-forge-demo-linux-x64/resources/app/node_modules/electron-compile/lib/compiler-host.js:282:34
    at next (<anonymous>)
    at step (/tmp/electron-compile-css-issue/out/electron-forge-demo-linux-x64/resources/app/node_modules/electron-compile/lib/compiler-host.js:41:191)
    at /tmp/electron-compile-css-issue/out/electron-forge-demo-linux-x64/resources/app/node_modules/electron-compile/lib/compiler-host.js:41:361

My guess as to what is happening is that it's failing to find both a CSS compiler and a fallback for the text/css file. It might be ignoring the app.min.css one because there are two dots in it and not one (and so it can't even find a sufficient mime type for it), but that last part is complete speculation.

[manikantag]

@malept Weird thing is just having .min.css (tow dots in the file name) is also not working. Try renaming the app.css to app.min.css (without actually minifying the contents). Same error will be thrown.

[malept]

I did mention that the last part of my statement was complete speculation 😃

I still think that this isn't specifically an Electron Forge issue, but I'll defer to one of the other maintainers with more experience with electron-compile.

[MarshallOfSound]

@manikantag Where is app.css in your project structure?

[MarshallOfSound]

@manikantag This issue has been fixed in this PR

electron-userland/electron-compile#163

[manikantag]

@manikantag Where is app.css in your project structure?

https://github.com/manikantag/electron-compile-css-issue/tree/master/src/css/app.css

[anaisbetts]

This is fixed in electron-compile v5.1.2, my apologies for the bug and thanks for the great repro app @manikantag

[manikantag]

@paulcbetts that is a very generous reply 👍

I've updated to 5.1.2, and is working fine with non-min css too. Thanks for the quick fix.