feat: add ability to specify additional npm rebuild args #881
Conversation
| if (additionalArgs) { | ||
| if (Array.isArray(additionalArgs)) { | ||
| additionalArgs.forEach(arg => npmExecArgs.push(arg)) | ||
| } else { |
| @@ -54,6 +54,14 @@ export function spawnNpmProduction(command: string, appDir: string, forceBuildFr | |||
| npmExecArgs.push("--build-from-source") | |||
| } | |||
|
|
|||
| if (additionalArgs) { | |||
| if (Array.isArray(additionalArgs)) { | |||
| additionalArgs.forEach(arg => npmExecArgs.push(arg)) | |||
There was a problem hiding this comment.
Please use spread operator here: npmExecArgs.push(...additionalArgs)
| @@ -237,11 +237,12 @@ export class Packager implements BuildInfo { | |||
| } | |||
| else { | |||
| const forceBuildFromSource = this.devMetadata.build.npmSkipBuildFromSource !== true | |||
| const additionalArgs = this.devMetadata.build.npmArgs | |||
There was a problem hiding this comment.
Var is used only in the one else branch, please inline.
|
Probably we should always pass |
|
@develar yes, that would work too. But |
I suppose it will be more good solution — to avoid explicit configuration. To simplify developer life. |
|
I've addressed those review notes. I think that electron-builder should handle setting the @develar Shall I create an issue? |
|
PR about abi version is welcome :) Thanks for spotting it. |
Whoops, when fixing code as per review in #881, accidentally broke the code.
I am building an electron app that uses native dependencies targeting multiple platforms. Prebuild binaries are available for all of them.
However when
npmSkipBuildFromSourceis enabled,prebuilddownloads the binary for the installed node version instead of the electron version. This can be easily handled by specifying a--abi=ELECTRON_ABI_VERSIONargument, but electron-builder does not allow this.This PR adds support for specifying any number of additional
npm rebuildarguments to allow working around issues outlined above.