Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should set --abi on npm rebuild to make prebuild work properly #882

Closed
mmckegg opened this issue Nov 5, 2016 · 2 comments
Closed

should set --abi on npm rebuild to make prebuild work properly #882

mmckegg opened this issue Nov 5, 2016 · 2 comments

Comments

@mmckegg
Copy link
Contributor

mmckegg commented Nov 5, 2016

  • Version: 7.21.0
  • Target: All

I am building an electron app that uses native dependencies targeting multiple platforms. Prebuild binaries are available for all of them.

However when npmSkipBuildFromSource is enabled, prebuild downloads the binary for the installed node version instead of the electron version. This can be easily handled by specifying a --abi=ELECTRON_ABI_VERSION argument, but electron-builder does not allow this.

#881 is a quick workaround to solve this, but as discussed with @develar, it would make sense for electron-builder to just set --abi=$(electron --abi) automatically.

@mmckegg
Copy link
Contributor Author

mmckegg commented Nov 5, 2016

@develar I'm happy to do a PR for this, just not right now, since #881 solves this for me. Might look again in a few weeks if no one else has taken it on.

@lgeiger
Copy link
Contributor

lgeiger commented Dec 18, 2016

Since prebuild v5.0.0+ it can prebuilt native modules against Electron headers and determines the ABI based on the --target and --runtime flags.

This makes it compatible with electron-builder. So this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants