You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am building an electron app that uses native dependencies targeting multiple platforms. Prebuild binaries are available for all of them.
However when npmSkipBuildFromSource is enabled, prebuild downloads the binary for the installed node version instead of the electron version. This can be easily handled by specifying a --abi=ELECTRON_ABI_VERSION argument, but electron-builder does not allow this.
#881 is a quick workaround to solve this, but as discussed with @develar, it would make sense for electron-builder to just set --abi=$(electron --abi) automatically.
The text was updated successfully, but these errors were encountered:
@develar I'm happy to do a PR for this, just not right now, since #881 solves this for me. Might look again in a few weeks if no one else has taken it on.
I am building an electron app that uses native dependencies targeting multiple platforms. Prebuild binaries are available for all of them.
However when
npmSkipBuildFromSource
is enabled,prebuild
downloads the binary for the installed node version instead of the electron version. This can be easily handled by specifying a--abi=ELECTRON_ABI_VERSION
argument, but electron-builder does not allow this.#881 is a quick workaround to solve this, but as discussed with @develar, it would make sense for electron-builder to just set
--abi=$(electron --abi)
automatically.The text was updated successfully, but these errors were encountered: