Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updating to the latest minor version of node 18. #7787

Closed
wants to merge 1 commit into from
Closed

feat: Updating to the latest minor version of node 18. #7787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ARG IMAGE_VERSION=base
FROM electronuserland/builder:$IMAGE_VERSION

ARG NODE_VERSION 18.15.0
ARG NODE_VERSION 18.18.0

# this package is used for snapcraft and we should not clear apt list - to avoid apt-get update during snap build
RUN curl -L https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz | tar xz -C /usr/local --strip-components=1 && \
unlink /usr/local/CHANGELOG.md && unlink /usr/local/LICENSE && unlink /usr/local/README.md && \
# https://github.com/npm/npm/issues/4531
echo "unsafe-perm true" > .npmrc
RUN npm i -g pnpm@8.6.10
RUN npm i -g pnpm@9.8.1s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the s in the version intentional or a mistype?

Also, if we're updating the pnpm version in our Dockerfiles, then we also need to update the pnpm versions specified here, otherwise unit tests won't pass
https://github.com/electron-userland/electron-builder/blob/master/package.json#L78
https://github.com/electron-userland/electron-builder/blob/master/.github/actions/pretest/action.yml#L13
https://github.com/electron-userland/electron-builder/blob/master/.github/actions/pnpm/action.yml#L7

With the updated pnpm version, I think the lockfile needs to be updated as well via pnpm i? :)

Alternatively, you could just update the ARG NODE_VERSION in this PR and not the pnpm version and I could take care of the rest