feat: Updating to the latest minor version of node 18. #7787
Conversation
…ate to npm version 9.8.1. Compatibility between node and npm sourced from https://nodejs.org/en/download/releases
|
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| # this package is used for snapcraft and we should not clear apt list - to avoid apt-get update during snap build | ||
| RUN curl -L https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz | tar xz -C /usr/local --strip-components=1 && \ | ||
| unlink /usr/local/CHANGELOG.md && unlink /usr/local/LICENSE && unlink /usr/local/README.md && \ | ||
| # https://github.com/npm/npm/issues/4531 | ||
| echo "unsafe-perm true" > .npmrc | ||
| RUN npm i -g pnpm@8.6.10 | ||
| RUN npm i -g pnpm@9.8.1s |
There was a problem hiding this comment.
Is the s in the version intentional or a mistype?
Also, if we're updating the pnpm version in our Dockerfiles, then we also need to update the pnpm versions specified here, otherwise unit tests won't pass
https://github.com/electron-userland/electron-builder/blob/master/package.json#L78
https://github.com/electron-userland/electron-builder/blob/master/.github/actions/pretest/action.yml#L13
https://github.com/electron-userland/electron-builder/blob/master/.github/actions/pnpm/action.yml#L7
With the updated pnpm version, I think the lockfile needs to be updated as well via pnpm i? :)
Alternatively, you could just update the ARG NODE_VERSION in this PR and not the pnpm version and I could take care of the rest
|
Closing in favor of #7824 |
feat: Updating to the latest minor version of node 18. This includes an update to npm version 9.8.1. Compatibility between node and npm sourced from https://nodejs.org/en/download/releases