-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nsis): display "Space required" text for NSIS installer #7531
feat(nsis): display "Space required" text for NSIS installer #7531
Conversation
🦋 Changeset detectedLatest commit: d1aecea The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Please add a |
Tests are throwing an error:
|
Adjusted code style, changed operations order in packArch electron-userland#7487
Added changeset electron-userland#7487
Done |
Fixed warning 6000 unknown variable/constant "{SYSTYPE_PTR}" detected electron-userland#7487
Fixed |
@mmaietta Fixed all comments. Could you check the PR again, please? ) |
Nice work! |
Implements #7487
Used NSIS
SectionSetSize
function to set correct space.