Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display required disk space in NSIS installer #7487

Closed
inickvel opened this issue Mar 20, 2023 · 5 comments
Closed

Display required disk space in NSIS installer #7487

inickvel opened this issue Mar 20, 2023 · 5 comments
Labels
Stale

Comments

@inickvel
Copy link
Contributor

  • Electron-Builder Version: 23.6.0
  • Node Version: 16.17.0
  • Electron Version: 22.0.2
  • Electron Type (current, beta, nightly): current
  • Target: nsis

Actual:
image

Expected:
image
@inickvel
Copy link
Contributor Author

Related issue: #1566

@mmaietta
Copy link
Collaborator

It's intentionally hidden per #1566 as NSIS can't compute size of 7z archives. Closing this.

If you'd like to have it back, add it to your custom .nsh scripts with this approach: #1566 (comment)

@inickvel
Copy link
Contributor Author

inickvel commented Mar 22, 2023 •
edited
Loading

@mmaietta Can you reopen this issue, please? I plan to fix it and make PR.
We can compute size before archiving for each arch and embed them as defines into nsh.

@mmaietta mmaietta reopened this Mar 22, 2023
inickvel pushed a commit to inickvel/electron-builder that referenced this issue Apr 10, 2023
feat(nsis): display required disk space
cbcab51 
electron-userland#7487
@inickvel inickvel mentioned this issue Apr 10, 2023
Merged
inickvel pushed a commit to inickvel/electron-builder that referenced this issue Apr 13, 2023
feat(nsis): display required disk space
c830d33 
electron-userland#7487
inickvel pushed a commit to inickvel/electron-builder that referenced this issue Apr 17, 2023
feat(nsis): display required disk space
da837a8 
Adjusted code style, changed operations order in packArch

electron-userland#7487
inickvel pushed a commit to inickvel/electron-builder that referenced this issue Apr 17, 2023
feat(nsis): display required disk space
1b9b529 
Added changeset

electron-userland#7487
inickvel pushed a commit to inickvel/electron-builder that referenced this issue Apr 17, 2023
feat(nsis): display required disk space
d1aecea 
Fixed warning 6000 unknown variable/constant "{SYSTYPE_PTR}" detected

electron-userland#7487
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 22, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inickvel @mmaietta