Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE #6964

Conversation

geovie
Copy link
Contributor

@geovie geovie commented Jun 28, 2022

When specifying appPackageUrl in the NsisWebOptions config APP_PACKAGE_URL_IS_INCOMPLETE would not be set to null and thus the installer would not include the packages.

Now I'm not sure if APP_PACKAGE_URL_IS_INCOMPLETE is even needed or if the check in webPackage.nsh could even be removed.

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

🦋 Changeset detected

Latest commit: a9a887d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit a9a887d
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62bf3d6707aa6900095ef6d7
😎 Deploy Preview https://deploy-preview-6964--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@grovesNL
Copy link
Contributor

grovesNL commented Oct 1, 2024

This seems to cause an extra path to be appended to appPackageUrl, see #7732

Is this expected or is there a known workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants