-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in nsis-web target for appPackageUrl
option
#8581
Comments
Would you mind sharing a minimum reproducible repo/gist for this issue? I'd like to create a unit test for this Re: the PR, I'm wondering if it's just safer to revert, but I'd still like to do the unit test to prevent future regressions. |
Hi would you like to share an example of nsis-web downloader. I made it but web-setup.exe says that 404 url not found. url is working. I upload x.nsis.7z file in github releases
|
You could take any plain electron-builder setup and add something like this: "nsisWeb": {
"appPackageUrl": "https://website.example/latest.7z",
"artifactName": "${productName} Setup.${ext}"
}, with any nsis-web target, so something like: "win": {
"target": [
{
"target": "nsis-web"
}
]
} The expectation is that we upload the produced 7z file at the location of the |
Thanks, it works fine. I found a bug which is I give full url to github release example: |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Still an issue |
Since #6964 the
appPackageUrl
doesn't work as intended because extra paths are appended to the URL, which means it's not possible to download the latest at a single URL (see #7732 for an example).My understanding is that
APP_PACKAGE_URL_IS_INCOMPLETE
intentionally tried to skip setting the package name based on architecture, instead using the name specified withappPackageUrl
, but #6964 will use the regular naming.The text was updated successfully, but these errors were encountered: