feat: make --no-sandbox optional for building with AppImage
#6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmaietta
reviewed
Nov 19, 2021
| @@ -20,7 +20,7 @@ export default class AppImageTarget extends Target { | |||
| super("appImage") | |||
|
|
|||
| this.desktopEntry = new Lazy<string>(() => | |||
| helper.computeDesktopEntry(this.options, "AppRun --no-sandbox %U", { | |||
| helper.computeDesktopEntry(this.options, `AppRun ${[...(this.options.executableArgs ?? ["--no-sandbox"]), "%U"].join(" ")}`, { | |||
There was a problem hiding this comment.
Can you please split in to its own const?
const args = this.options.executableArgs?.join(" ") || "--no-sandbox"
helper.computeDesktopEntry(this.options, `AppRun ${args} %U`, {
mmaietta
changed the title
--no-sandbox optional for building with AppImage--no-sandbox optional for building with AppImage
mmaietta
approved these changes
Nov 22, 2021
|
Can you please rebase off latest master? That should resolve the test failures |
devinbinnie
force-pushed
the
appimage_optional_no_sandbox
branch
from
8d776e8 to
4838fcf
Compare
|
@mmaietta Done, I think I accidentally wiped out one of the |
taratatach
added a commit
to cozy-labs/cozy-desktop
that referenced
this pull request
Dec 9, 2022
This runtime option disables the chromium sandbox. It was added as a default option in `electron-builder` v22.10.3 (see electron-userland/electron-builder#4496) because the required kernel privileges might not be available on the user's computer (e.g. in Debian). However, these privileges might be available on some computers and the sandbox should be used in this case. Thankfully, `electron-builder` v22.14.8 makes this optional when using the build option `executableArgs` (see electron-userland/electron-builder#6429). Since we don't have any arguments to pass to Cozy Desktop, we'll just add an empty argument to the list to prevent the use of `--no-sandbox` in the Desktop entry. We'll still add the option ourselves when necesary (see ./build/launcher-script.sh`).
taratatach
added a commit
to cozy-labs/cozy-desktop
that referenced
this pull request
Dec 12, 2022
This runtime option disables the chromium sandbox. It was added as a default option in `electron-builder` v22.10.3 (see electron-userland/electron-builder#4496) because the required kernel privileges might not be available on the user's computer (e.g. in Debian). However, these privileges might be available on some computers and the sandbox should be used in this case. Thankfully, `electron-builder` v22.14.8 makes this optional when using the build option `executableArgs` (see electron-userland/electron-builder#6429). Since we don't have any arguments to pass to Cozy Desktop, we'll just add an empty argument to the list to prevent the use of `--no-sandbox` in the Desktop entry. We'll still add the option ourselves when necesary (see ./build/launcher-script.sh`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
--no-sandboxis hardcoded into the arguments list when building anAppImage. This seems to be a good default for many implementations, but doesn't work for all of them. Example being the Mattermost Desktop App (see this issue: mattermost/desktop#1804)I've created this PR in order to potentially add an override option for users to specify their own arguments when launching the AppImage, using the
executableArgsfield which doesn't appear to be used by the AppImage at this time.Let me know if this change makes sense and if I can make any further edits to support this.