Skip to content

Commit

Permalink
build/linux: Don't use --no-sandbox by default
Browse files Browse the repository at this point in the history
  This runtime option disables the chromium sandbox. It was added as a
  default option in `electron-builder` v22.10.3 (see
  electron-userland/electron-builder#4496)
  because the required kernel privileges might not be available on the
  user's computer (e.g. in Debian).

  However, these privileges might be available on some computers and the
  sandbox should be used in this case.
  Thankfully, `electron-builder` v22.14.8 makes this optional when using
  the build option `executableArgs` (see
  electron-userland/electron-builder#6429).

  Since we don't have any arguments to pass to Cozy Desktop, we'll just
  add an empty argument to the list to prevent the use of `--no-sandbox`
  in the Desktop entry.
  We'll still add the option ourselves when necesary (see
  ./build/launcher-script.sh`).
  • Loading branch information
taratatach committed Dec 12, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent dc3a17c commit 715ba46
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
@@ -82,6 +82,7 @@ linux:
services. Your freedom to chose is why you can trust us.
appImage:
artifactName: 'Cozy-Drive-${version}-${arch}.${ext}'
executableArgs: [" "] # do not use --no-sandbox by default (see build/launcher-script.sh for details on when it should be used)

extraResources:
- from: 'build/launcher-script.sh'

0 comments on commit 715ba46

Please sign in to comment.