fix: Configure build resources directory #184 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @stefanjudis to be a potential reviewer |
| @@ -6,11 +6,11 @@ | |||
| <excludeFolder url="file://$MODULE_DIR$/example-app" /> | |||
| <excludeFolder url="file://$MODULE_DIR$/node_modules" /> | |||
| <excludeFolder url="file://$MODULE_DIR$/out" /> | |||
| <excludeFolder url="file://$MODULE_DIR$/test/_published" /> | |||
There was a problem hiding this comment.
Otherwise IDE completion tries to use fake package.json — so, just move to separate directory.
|
@stefanjudis lgtm :) |
|
Jap, go ahead... Im currently moving flats... So no contributions from my side. Sorry about that. But ci is failing... ;) |
develar
force-pushed
the
184
branch
2 times, most recently
from
932a885 to
4975678
Compare
|
CI tests failed because:
So, for now, we don't use |
develar
force-pushed
the
184
branch
5 times, most recently
from
62afe5b to
c168474
Compare
Tests refactored to simplify new test addition ESLint added to check test code Closes electron-userland#184, electron-userland#196
develar
added a commit
that referenced
this pull request
Mar 3, 2016
fix: Configure build resources directory #184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests refactored to simplify new test addition
ESLint added to check test code
Closes #184