You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To create a linux installer I had to change the application package.json "author":"blah" to "author":{
"name":"blah", "email": "[email protected]"}. This had a side effect in the windows installer where the authors field (Publisher in the add/remove programs) to read [Object object].
Adding the owners field in the win section of the development package.json fixes the problem.
Having in mind that the project uses electronjs/windows-installer I filed a PR there that fixes the problem (it was just a typo https://github.com/electronjs/windows-installer/pull/16/files).
And then it hit me.
While the docs state that electron-packager and https://github.com/electronjs/windows-installer are used under the hood, the truth is that some temporary-forks are actually being used.
I really don't see any reason (nor have the time to do so) to create PRs on temporary forks.
For the typo mentioned I might have done it but I don't feel like altering the following code found in electron-winstaller-temp-fork/index.js metadata.authors = (ref4 = (ref5 = (ref6 = metadata.author) != null ? ref6.name : void 0) != null ? ref5 : metadata.author) != null ? ref4 : '';
Maybe somebody else does....
The text was updated successfully, but these errors were encountered:
develar
added a commit
to develar/electron-builder
that referenced
this issue
Mar 3, 2016
To create a linux installer I had to change the application package.json "author":"blah" to "author":{
"name":"blah", "email": "[email protected]"}. This had a side effect in the windows installer where the authors field (Publisher in the add/remove programs) to read [Object object].
Adding the owners field in the win section of the development package.json fixes the problem.
Having in mind that the project uses electronjs/windows-installer I filed a PR there that fixes the problem (it was just a typo https://github.com/electronjs/windows-installer/pull/16/files).
And then it hit me.
While the docs state that electron-packager and https://github.com/electronjs/windows-installer are used under the hood, the truth is that some temporary-forks are actually being used.
I really don't see any reason (nor have the time to do so) to create PRs on temporary forks.
For the typo mentioned I might have done it but I don't feel like altering the following code found in electron-winstaller-temp-fork/index.js
metadata.authors = (ref4 = (ref5 = (ref6 = metadata.author) != null ? ref6.name : void 0) != null ? ref5 : metadata.author) != null ? ref4 : '';
Maybe somebody else does....
The text was updated successfully, but these errors were encountered: