Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Icons (not updating on dist output) #840

Closed
philcockfield opened this issue Oct 21, 2016 · 10 comments · May be fixed by qcif/data-curator#563
Closed

Changing Icons (not updating on dist output) #840

philcockfield opened this issue Oct 21, 2016 · 10 comments · May be fixed by qcif/data-curator#563

Comments

@philcockfield
Copy link

  • Version: 7.13.0
  • Target: mac

On the Mac, I'm changing the icons that are in the build folder. When I package the app, the new icon is not being updated consistently across all of the output files.

Is there a build-cache somewhere that I need to delete?

I have tried deleting the Xcode/DerivedData but that makes no difference.

Thanks.

@develar
Copy link
Member

develar commented Oct 21, 2016

Do you mean that icon of your YourName.app in the Finder has old icon?

@philcockfield
Copy link
Author

The build folder with the latest icon selected - looks like this:

image

The built dist folder after a build has this:

image

Which is a previous incarnation of the icon.

And the DMG when opened does have the latest version of the icon.

image

@philcockfield
Copy link
Author

Furthermore, it's displaying differently on retina and non-retina screens:

Non-retina

image

Retina

image

I wonder if this is perhaps. the Finder caching things.

@jessb321
Copy link

@philcockfield I did a bit of research on the topic - and it seems that your hunch was correct - see here for a potential fix for it!

@develar
Copy link
Member

develar commented Oct 22, 2016

I can confirm, that it is Finder cache issue — not your app or electron-builder issue.

@philcockfield
Copy link
Author

Pulling a bunch of those suggestions together, I have this "nuke'em" set of commands:

sudo find /private/var/folders/ -name com.apple.dock.iconcache -exec rm {};
sudo find /private/var/folders/ -name com.apple.iconservices -exec rm -rf {};
sudo rm -rf /Library/Caches/com.apple.iconservices.store
killall Dock
killall Finder

Not totally working - the DMG is still lagging behind, but some of the icons are now updating. Thanks everyone.

@develar
Copy link
Member

develar commented Oct 24, 2016

Help-wanted — electron-builder should not confuse users. Probably we should touch application executable to update cache.

@philcockfield
Copy link
Author

What would be the file to touch?

In this case, would it be:

touch /<path>/dist/mac/Team DB.app
touch /<path>/dist/mac/Team DB.app/Contents/Info.plist

image

@develar
Copy link
Member

develar commented Nov 12, 2016

8.4.1+ will touch .app directory.

@philcockfield
Copy link
Author

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants